Last Comment Bug 664464 - Unlink XBL some more
: Unlink XBL some more
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: XBL (show other bugs)
: unspecified
: x86_64 Linux
: -- normal with 1 vote (vote)
: ---
Assigned To: Olli Pettay [:smaug]
:
: Andrew Overholt [:overholt]
Mentors:
Depends on:
Blocks: strongparent
  Show dependency treegraph
 
Reported: 2011-06-15 09:28 PDT by Olli Pettay [:smaug]
Modified: 2011-06-22 09:03 PDT (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
patch (2.06 KB, patch)
2011-06-15 09:28 PDT, Olli Pettay [:smaug]
jonas: review+
Details | Diff | Splinter Review

Description Olli Pettay [:smaug] 2011-06-15 09:28:44 PDT
Created attachment 539560 [details] [diff] [review]
patch
Comment 1 Jonas Sicking (:sicking) No longer reading bugmail consistently 2011-06-21 22:19:43 PDT
Comment on attachment 539560 [details] [diff] [review]
patch

Why is mNextBinding needed? Leaving just those pointers should never create a cycle unless we have some really horrible bugs.

r=me if you explain why that's unlinked.
Comment 2 Olli Pettay [:smaug] 2011-06-22 05:55:58 PDT
mNextBinding may have mContent pointing to element which keeps
document alive.
Comment 3 Olli Pettay [:smaug] 2011-06-22 06:04:52 PDT
Though, ofc mNextBinding should unlink its mContent. 
But still, I'd like to keep unlinking "complete" when possible.
Comment 4 Olli Pettay [:smaug] 2011-06-22 06:07:48 PDT
http://hg.mozilla.org/mozilla-central/rev/db6d8ef5b27c
Comment 5 Jonas Sicking (:sicking) No longer reading bugmail consistently 2011-06-22 09:03:50 PDT
But that gets unlinked, right?

Note You need to log in before you can comment on or make changes to this bug.