Closed
Bug 664467
Opened 14 years ago
Closed 14 years ago
Unlink content/html some more
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
People
(Reporter: smaug, Assigned: smaug)
References
Details
Attachments
(2 files)
|
5.46 KB,
patch
|
sicking
:
review+
|
Details | Diff | Splinter Review |
|
5.73 KB,
patch
|
Details | Diff | Splinter Review |
I need to re-verify if there are still other cases when we should
unlink, but I'll file followups when needed.
Attachment #539563 -
Flags: review?(jonas)
|
||
Updated•14 years ago
|
OS: Linux → All
Hardware: x86_64 → All
Version: unspecified → Trunk
Comment on attachment 539563 [details] [diff] [review]
patch
Review of attachment 539563 [details] [diff] [review]:
-----------------------------------------------------------------
r=me either way.
::: content/html/content/src/nsHTMLInputElement.cpp
@@ +687,5 @@
>
> +NS_IMPL_CYCLE_COLLECTION_UNLINK_BEGIN_INHERITED(nsHTMLInputElement,
> + nsGenericHTMLFormElement)
> + NS_IMPL_CYCLE_COLLECTION_UNLINK_NSCOMPTR(mControllers)
> + //XXX should unlink more?
Wouldn't hurt to do mFiles and mFileList as well. It'd be needed if we make files trace their wrapper when an expando is set.
Also, who owns and traverses mInputData.mState?
Attachment #539563 -
Flags: review?(jonas) → review+
|
Assignee | |
Comment 2•14 years ago
|
||
mInputData.mState is a reference variable I don't see why it should be
traversed.
|
|
Assignee | |
Comment 3•14 years ago
|
||
Er, I was looking at wrong code.
|
|
Assignee | |
Comment 4•14 years ago
|
||
|
|
Assignee | |
Comment 5•14 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/fde2138b435f
the input element traverses mInputData.mState.
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•