Last Comment Bug 664467 - Unlink content/html some more
: Unlink content/html some more
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: DOM: Core & HTML (show other bugs)
: Trunk
: All All
: -- normal with 1 vote (vote)
: ---
Assigned To: Olli Pettay [:smaug]
:
Mentors:
Depends on:
Blocks: strongparent
  Show dependency treegraph
 
Reported: 2011-06-15 09:33 PDT by Olli Pettay [:smaug]
Modified: 2011-06-21 14:47 PDT (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
patch (5.46 KB, patch)
2011-06-15 09:33 PDT, Olli Pettay [:smaug]
jonas: review+
Details | Diff | Splinter Review
+files and filelist (5.73 KB, patch)
2011-06-21 14:11 PDT, Olli Pettay [:smaug]
no flags Details | Diff | Splinter Review

Description Olli Pettay [:smaug] 2011-06-15 09:33:40 PDT
Created attachment 539563 [details] [diff] [review]
patch

I need to re-verify if there are still other cases when we should
unlink, but I'll file followups when needed.
Comment 1 Jonas Sicking (:sicking) No longer reading bugmail consistently 2011-06-15 14:17:48 PDT
Comment on attachment 539563 [details] [diff] [review]
patch

Review of attachment 539563 [details] [diff] [review]:
-----------------------------------------------------------------

r=me either way.

::: content/html/content/src/nsHTMLInputElement.cpp
@@ +687,5 @@
>  
> +NS_IMPL_CYCLE_COLLECTION_UNLINK_BEGIN_INHERITED(nsHTMLInputElement,
> +                                                  nsGenericHTMLFormElement)
> +  NS_IMPL_CYCLE_COLLECTION_UNLINK_NSCOMPTR(mControllers)
> +  //XXX should unlink more?

Wouldn't hurt to do mFiles and mFileList as well. It'd be needed if we make files trace their wrapper when an expando is set.

Also, who owns and traverses mInputData.mState?
Comment 2 Olli Pettay [:smaug] 2011-06-21 13:40:22 PDT
mInputData.mState is a reference variable  I don't see why it should be
traversed.
Comment 3 Olli Pettay [:smaug] 2011-06-21 13:41:40 PDT
Er, I was looking at wrong code.
Comment 4 Olli Pettay [:smaug] 2011-06-21 14:11:15 PDT
Created attachment 540883 [details] [diff] [review]
+files and filelist
Comment 5 Olli Pettay [:smaug] 2011-06-21 14:47:02 PDT
http://hg.mozilla.org/mozilla-central/rev/fde2138b435f

the input element traverses mInputData.mState.

Note You need to log in before you can comment on or make changes to this bug.