The default bug view has changed. See this FAQ.

Unlink content/html some more

RESOLVED FIXED

Status

()

Core
DOM: Core & HTML
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: smaug, Assigned: smaug)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

Created attachment 539563 [details] [diff] [review]
patch

I need to re-verify if there are still other cases when we should
unlink, but I'll file followups when needed.
Attachment #539563 - Flags: review?(jonas)
OS: Linux → All
Hardware: x86_64 → All
Version: unspecified → Trunk
Comment on attachment 539563 [details] [diff] [review]
patch

Review of attachment 539563 [details] [diff] [review]:
-----------------------------------------------------------------

r=me either way.

::: content/html/content/src/nsHTMLInputElement.cpp
@@ +687,5 @@
>  
> +NS_IMPL_CYCLE_COLLECTION_UNLINK_BEGIN_INHERITED(nsHTMLInputElement,
> +                                                  nsGenericHTMLFormElement)
> +  NS_IMPL_CYCLE_COLLECTION_UNLINK_NSCOMPTR(mControllers)
> +  //XXX should unlink more?

Wouldn't hurt to do mFiles and mFileList as well. It'd be needed if we make files trace their wrapper when an expando is set.

Also, who owns and traverses mInputData.mState?
Attachment #539563 - Flags: review?(jonas) → review+
mInputData.mState is a reference variable  I don't see why it should be
traversed.
Er, I was looking at wrong code.
Created attachment 540883 [details] [diff] [review]
+files and filelist
http://hg.mozilla.org/mozilla-central/rev/fde2138b435f

the input element traverses mInputData.mState.
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.