Switch suite/mailnews to use Services.scriptloader

RESOLVED FIXED in seamonkey2.4

Status

SeaMonkey
MailNews: General
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: Ian Neal, Assigned: Ian Neal)

Tracking

Trunk
seamonkey2.4
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

7 years ago
Created attachment 539686 [details] [diff] [review]
Switch to Services.jsm [Checked in: Comment 3]

At the moment we have Services.jsm imported but we're not making full use of it.
This patch:
* Switches code in suite/mailnews to make use of Services.scriptloader

Not sure if we still need to test for Services.scriptloader
Attachment #539686 - Flags: review?(neil)

Comment 1

7 years ago
Comment on attachment 539686 [details] [diff] [review]
Switch to Services.jsm [Checked in: Comment 3]

You can drop that test, it was bogus anyway (previous code would throw).

[I wonder whether utils.js should be turned into a module...]
Attachment #539686 - Flags: review?(neil) → review+

Comment 2

7 years ago
Just out of interest why are we using mozIJSSubScriptLoader() rather than declaring it in a <script> tag.

> [I wonder whether utils.js should be turned into a module...]
I was wondering the same thing.
(Assignee)

Comment 3

7 years ago
Comment on attachment 539686 [details] [diff] [review]
Switch to Services.jsm [Checked in: Comment 3]

Checked in without redundant test
http://hg.mozilla.org/comm-central/rev/86e139ec514b
Attachment #539686 - Attachment description: Switch to Services.jsm → Switch to Services.jsm [Checked in: Comment 3]
(Assignee)

Comment 4

7 years ago
(In reply to comment #1)
> Comment on attachment 539686 [details] [diff] [review] [review]
> Switch to Services.jsm [Checked in: Comment 3]
> 
> You can drop that test, it was bogus anyway (previous code would throw).
> 
> [I wonder whether utils.js should be turned into a module...]

Logged as Bug 664697
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.4
(Assignee)

Updated

7 years ago
Blocks: 664838
You need to log in before you can comment on or make changes to this bug.