664612 - Switch suite/mailnews to use Services.scriptloader

Status: RESOLVED FIXED

(SeaMonkey :: MailNews: General, defect)

Description

[Ian Neal]

Attachment: Switch to Services.jsm [Checked in: Comment 3]

At the moment we have Services.jsm imported but we're not making full use of it.
This patch:
* Switches code in suite/mailnews to make use of Services.scriptloader

Not sure if we still need to test for Services.scriptloader

Comment 1

[[e-mail]]

Comment on attachment 539686 [details] [diff] [review]
Switch to Services.jsm [Checked in: Comment 3]

You can drop that test, it was bogus anyway (previous code would throw).

[I wonder whether utils.js should be turned into a module...]

Comment 2

[Philip Chee]

Just out of interest why are we using mozIJSSubScriptLoader() rather than declaring it in a <script> tag.

> [I wonder whether utils.js should be turned into a module...]
I was wondering the same thing.

Comment 3

[Ian Neal]

Comment on attachment 539686 [details] [diff] [review]
Switch to Services.jsm [Checked in: Comment 3]

Checked in without redundant test
http://hg.mozilla.org/comm-central/rev/86e139ec514b

Comment 4

[Ian Neal]

(In reply to comment #1)
> Comment on attachment 539686 [details] [diff] [review] [review]
> Switch to Services.jsm [Checked in: Comment 3]
> 
> You can drop that test, it was bogus anyway (previous code would throw).
> 
> [I wonder whether utils.js should be turned into a module...]

Logged as Bug 664697