The default bug view has changed. See this FAQ.

When a tab has been removed, cut off its link to the browser

VERIFIED FIXED in Firefox 7

Status

()

Firefox
Tabbed Browser
VERIFIED FIXED
6 years ago
5 years ago

People

(Reporter: dao, Assigned: dao)

Tracking

(Blocks: 1 bug, {mlk})

Trunk
Firefox 7
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

6 years ago
Created attachment 539742 [details] [diff] [review]
patch

In order to release the browser when something is erroneously holding a reference to a removed tab, we should cut off the link between the two.

mochitest-browser-chrome passed on try with this patch.
Attachment #539742 - Flags: review?(gavin.sharp)
(Assignee)

Updated

6 years ago
Blocks: 658738
Comment on attachment 539742 [details] [diff] [review]
patch

Why null out linkedPanel? It's just an ID.

It's hard to know whether anyone would be depending on tabs keeping their browsers alive, but I guess there isn't much to do aside from trying it and seeing what breaks.
Attachment #539742 - Flags: review?(gavin.sharp) → review+
(Assignee)

Comment 2

6 years ago
Created attachment 540227 [details] [diff] [review]
patch v2

removed the linkedPanel part, added a test
Attachment #539742 - Attachment is obsolete: true
(Assignee)

Comment 3

6 years ago
http://hg.mozilla.org/mozilla-central/rev/3dc72d090e70
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → Firefox 7

Updated

6 years ago
Keywords: mlk

Comment 4

6 years ago
Setting resolution to Verified Fixed on Mozilla/5.0 (Windows NT 6.1; rv:7.0) Gecko/20100101 Firefox/7.0
Status: RESOLVED → VERIFIED
(Assignee)

Updated

5 years ago
Blocks: 489622
You need to log in before you can comment on or make changes to this bug.