664696 - GCLI commands should be reviewed for security issues

Status: RESOLVED FIXED

(DevTools :: Console, defect)

Description

[Joe Walker [:jwalker]]

From security review: "have mrbkap review implementations, especially ones that explicitly wrap or unwrap"

Comment 1

[Joe Walker [:jwalker]]

mrbkap - the code for this review isn't written yet, so feel free to relax for a while :)

Comment 2

[Joe Walker [:jwalker]]

Moving GCLI bugs to Developer Tools: Console. Filter on 'baked beans are off'.

Comment 3

[Joe Walker [:jwalker]]

Docs done:
  https://etherpad.mozilla.org/gcli-sec-review-2011
Or:
  https://github.com/joewalker/gcli/blob/secreview-664696/docs/review/security-review-2011.md

Comment 4

[Joe Walker [:jwalker]]

Have you guys had a chance to look over the docs yet? I'd like to schedule a security review if one is needed. Thanks.

Comment 5

[Curtis Koenig [:curtisk-use curtis.koenig+bzATgmail.com]]]

dchan is assigned to look at this, if he sees the need for a meeting he will let you/me know.

Comment 6

[Joe Walker [:jwalker]]

(In reply to Curtis Koenig [:curtisk] from comment #5)
> dchan is assigned to look at this, if he sees the need for a meeting he will
> let you/me know.

So I'm going to assume that we're good unless you contact me.
Thanks.

Comment 7

[David Chan [:dchan]]

Commented in the wrong bug. The security review is complete. Thanks Joe!

See bug #664693 for full comment.

Joe: Your concern about screenshot is answered in there.

Comment 8

[Joe Walker [:jwalker]]

Thanks for the review.

Anyone opposed to me closing this bug? I'll assume that I should remove the sec-review-needed whiteboard tag too?