Closed Bug 664696 Opened 8 years ago Closed 8 years ago

GCLI commands should be reviewed for security issues

Categories

(DevTools :: Console, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: jwalker, Assigned: dchanm+bugzilla)

References

()

Details

(Whiteboard: [sg:audit][secr:dchan])

From security review: "have mrbkap review implementations, especially ones that explicitly wrap or unwrap"
Whiteboard: [sg:audit]
mrbkap - the code for this review isn't written yet, so feel free to relax for a while :)
Blocks: GCLI-JS
No longer blocks: GCLI-HELP
Whiteboard: [sg:audit] → [sg:audit][minotaur]
Assignee: nobody → jwalker
No longer depends on: 664693
Whiteboard: [sg:audit][minotaur] → [sg:audit]
Blocks: GCLI-SHIP
No longer blocks: GCLI-JS
Whiteboard: [sg:audit] → [sg:audit][secr:dchan]
Moving GCLI bugs to Developer Tools: Console. Filter on 'baked beans are off'.
Component: Developer Tools → Developer Tools: Console
Have you guys had a chance to look over the docs yet? I'd like to schedule a security review if one is needed. Thanks.
dchan is assigned to look at this, if he sees the need for a meeting he will let you/me know.
(In reply to Curtis Koenig [:curtisk] from comment #5)
> dchan is assigned to look at this, if he sees the need for a meeting he will
> let you/me know.

So I'm going to assume that we're good unless you contact me.
Thanks.
Assignee: jwalker → dchan+bugzilla
Commented in the wrong bug. The security review is complete. Thanks Joe!

See bug #664693 for full comment.

Joe: Your concern about screenshot is answered in there.
Thanks for the review.

Anyone opposed to me closing this bug? I'll assume that I should remove the sec-review-needed whiteboard tag too?
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Flags: sec-review+
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.