Closed Bug 664723 Opened 9 years ago Closed 9 years ago

update removed-files.in for bug 643816

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(firefox6 fixed)

VERIFIED FIXED
mozilla7
Tracking Status
firefox6 --- fixed

People

(Reporter: bhearsum, Assigned: bhearsum)

References

Details

Attachments

(1 file)

Bug 643816 caused D3DCompiler_42.dll and d3dx9_42.dll to be removed, we need to add them to removed-files.in still.
Attached patch add themSplinter Review
Attachment #539798 - Flags: review?(khuey)
Comment on attachment 539798 [details] [diff] [review]
add them

Ugh, it sucks that this is going to happen silently every time we switch SDKs.
Attachment #539798 - Flags: review?(khuey) → review+
Comment on attachment 539798 [details] [diff] [review]
add them

Drivers, this patch causes the updater to remove the old, now unused directx files, when someone updates via AUS. There's no harm to having them around functionality wise (they go unused in favour of new ones), but removing them cleans up some of our update verification tests.

Already landed this on mozilla-central.
Attachment #539798 - Flags: approval-mozilla-aurora?
Assignee: nobody → bhearsum
Status: NEW → ASSIGNED
OS: Linux → All
Hardware: x86_64 → All
Version: unspecified → Trunk
Attachment #539798 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment on attachment 539798 [details] [diff] [review]
add them

Landed on aurora, too.
Attachment #539798 - Flags: checkin+
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Mozilla/5.0 (X11; Linux i686; rv:7.0a1) Gecko/20110627 Firefox/7.0a1

The two files were added to removed-files.in

D3DCompiler_42.dll
d3dx9_42.dll

Setting status to Verified Fixed.
Status: RESOLVED → VERIFIED
Blocks: 668723
Blocks: 673884
Component: Build Config → General
Product: Firefox → Firefox Build System
Target Milestone: Firefox 7 → mozilla7
You need to log in before you can comment on or make changes to this bug.