66474 - "Copy and Folder settings" or "Copies and Folder settings"?

Status: RESOLVED WORKSFORME

(SeaMonkey :: MailNews: Account Configuration, defect, P5)

Description

[Håkan Waara]

In Account Settings there's an inconsistency in the naming of a setting.

In the left panel it says "Copies and Folder settings", but when you click it,
and read the title on the panel it says "Copy and Folder settings".

I think we should edit one of these to match the other, the question is just,
which of them?

(Personally I prefer the "Copies..".)

Comment 1

[jglick]

I'd like to see "Copies and Folders Settings - <accountname>"

Comment 2

[Håkan Waara]

Okay. When we're on it, the "Server" item's title is "Server Settings" in the
panel. 

Can we merge that issue with this bug and just change the summary?

Comment 3

[jglick]

I'd like to see "Server Settings - <accountname>" if possible.

Comment 4

[jglick]

I just updated the Account Settings spec (including the preferred panel names.
http://www.mozilla.org/mailnews/specs/accounts/

Comment 5

[[e-mail] (gone - use [e-mail] instead)]

Attachment: Patch to now say in the Account Manager title, "Copies and Folder Settings"

Comment 6

[[e-mail] (gone - use [e-mail] instead)]

I'm taking this bug, Hwaara doesn't mind.

Comment 7

[[e-mail] (gone - use [e-mail] instead)]

Hwaara, please review, and Bhuvan if you could SR=, thanks!  BTW, I can't 
change following yet, it requires some JavaScript stuff, I'll file a new bug on 
that, once this fix gets reviewed and checked in.

------- Additional Comments From [e-mail] 2001-01-24 16:58 -------

I'd like to see "Server Settings - <accountname>" if possible.

Comment 8

[Håkan Waara]

Please also fix the little bug I mentioned in my last comment. Thanks

Comment 9

[[e-mail] (gone - use [e-mail] instead)]

Attachment: This patch addresses all except the JavaScript <name> issue.

Comment 10

[[e-mail] (gone - use [e-mail] instead)]

Re-assigning to Racham.  We can do a couple things here:

1. Someone can checkin my fixes and we can leave this open, and someone can fix
the JavaScript to get the serverType.
2. We can wait until all the code is done and checkin then.

I'd like to see #1, either way, this bug will remain open.

Comment 11

[racham]

Attachment: Complete patch to reflect account name on all panel titles

Comment 12

[racham]

Adding gayatri and seth to the cc list.

Comment 13

[timeless]

i think we settled on %s and string bundles. jag?

Comment 14

[Peter "jag" Annema]

Yes. Basically, %S is easier on the l10n groups, but I'll let Alec convince you,
for it is he who convinced me :-)

Comment 15

[Alec Flett]

yes, please use %S, do not use JS's regexp-style substitution.

Comment 16

[racham]

Attachment: patch reworked with %S format

Comment 17

[racham]

Please review the latest patch (id=25729).thanks. 

Comment 18

[Peter "jag" Annema]

What happened to that beautiful <stringbundle/> using patch?
<stringbundle/> even has |getFormattedString(aKey, aStringArray);|...

Comment 19

[Alec Flett]

looking over it, I also think this is kind of a hacky fix... seems like we
should be adding the string to the tree by adding a new property in the account
datasource, updating the template to reflect this string into the DOM, and then
automatically formatting whatever string is sitting in the DOM. That way we
don't have to modify each individual panel.

Comment 20

[scottputterman]

Moving to future milestone for racham as the developer (unless the current patch
is accepted). If someone else wants to come up with the better fix, that would
be cool.

Comment 21

[racham]

Thanks Scott. I was going to work on the new patch only after all my 0.9 bugs as
this is a P5. So, that's fine.

Comment 22

[[not reading bugmail]]

Could this be a polish bug for patch-maker?

Comment 23

[Håkan Waara]

sure

Comment 24

[(not reading, please use [e-mail] instead)]

mass re-assign.

Comment 25

[Henrik Lynggaard Hansen]

The account Manager currently reads:

Title: Mail & Newsgroup Account Settings
Tree: Copies & Folders
Panel headline: Copies & Folders

The account name only appear on the parent in the tree and not any of the child
panels.

I think this bug is now an non-issue, Can it be closed ?

Comment 26

[Tim Meader]

Agreed, please close this bug.

Comment 27

[Mikael Parknert]

(In reply to comment #26)
> Agreed, please close this bug.

Closing

Comment 28

[Jason Bassford]

> I think this bug is now an non-issue

And I see that no patch was actually checked in.  Since no other bug/patch was
identified as the reason for things now being acceptable, this should be WORKSFORME.