Closed Bug 664740 Opened 13 years ago Closed 13 years ago

Create helper function for getting nsILocalFile complexValue prefs

Categories

(SeaMonkey :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
seamonkey2.4

People

(Reporter: iannbugzilla, Assigned: iannbugzilla)

References

Details

Attachments

(1 file)

At the moment, in MsgComposeCommands.js we have GetLastAttachDirectory function which could be moved into utilityOverlay.js, adapted to take a pref name argument and used more generally.
This patch:
* Creates replacement helper in utilityOverlay.js
* Removes GetLastAttachDirectory from MsgComposeCommands.js
* Switches MsgComposeCommands.js to use new helper.
* Switches pageInfo.js to use new helper.

Other potential users could be done in a followup patch.
Attachment #539804 - Flags: review?(neil)
Comment on attachment 539804 [details] [diff] [review]
GetLocalFilePref helper [Checked in: Comment 2]

I'm surprised Firefox haven't updated their page info either, but you get a different dir depending on whether you have a single or multiple files ;-)
Attachment #539804 - Flags: review?(neil) → review+
Comment on attachment 539804 [details] [diff] [review]
GetLocalFilePref helper [Checked in: Comment 2]

http://hg.mozilla.org/comm-central/rev/91fa9d39ce94
Attachment #539804 - Attachment description: GetLocalFilePref helper → GetLocalFilePref helper [Checked in: Comment 2]
(In reply to comment #1)
> Comment on attachment 539804 [details] [diff] [review] [review]
> GetLocalFilePref helper [Checked in: Comment 2]
> 
> I'm surprised Firefox haven't updated their page info either, but you get a
> different dir depending on whether you have a single or multiple files ;-)

single vs multiple issue has been logged as bug 664832
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.4
Blocks: 664838
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: