664740 - Create helper function for getting nsILocalFile complexValue prefs

Status: RESOLVED FIXED

(SeaMonkey :: General, defect)

Description

[Ian Neal]

Attachment: GetLocalFilePref helper [Checked in: Comment 2]

At the moment, in MsgComposeCommands.js we have GetLastAttachDirectory function which could be moved into utilityOverlay.js, adapted to take a pref name argument and used more generally.
This patch:
* Creates replacement helper in utilityOverlay.js
* Removes GetLastAttachDirectory from MsgComposeCommands.js
* Switches MsgComposeCommands.js to use new helper.
* Switches pageInfo.js to use new helper.

Other potential users could be done in a followup patch.

Comment 1

[[e-mail]]

Comment on attachment 539804 [details] [diff] [review]
GetLocalFilePref helper [Checked in: Comment 2]

I'm surprised Firefox haven't updated their page info either, but you get a different dir depending on whether you have a single or multiple files ;-)

Comment 2

[Ian Neal]

Comment on attachment 539804 [details] [diff] [review]
GetLocalFilePref helper [Checked in: Comment 2]

http://hg.mozilla.org/comm-central/rev/91fa9d39ce94

Comment 3

[Ian Neal]

(In reply to comment #1)
> Comment on attachment 539804 [details] [diff] [review] [review]
> GetLocalFilePref helper [Checked in: Comment 2]
> 
> I'm surprised Firefox haven't updated their page info either, but you get a
> different dir depending on whether you have a single or multiple files ;-)

single vs multiple issue has been logged as bug 664832