664788 - console.log(message) doesn't show leading whitespace in message

Status: VERIFIED FIXED

(DevTools :: General, defect)

Description

[Ian Bicking (:ianbicking)]

I sometimes want to do:

  console.log('Some stuff:');
  console.log('  example:', foo);
  console.log('  also:', foo2);

But the leading whitespace is not displayed.  I wouldn't put those spaces there if I didn't want them to be there ;)

Comment 1

[Philip Chee]

IMHO, I think this is an extreme edge case. Most people won't care.

Comment 2

[Panos Astithas (he/him) [:past] (please ni?)]

Attachment: Patch v1

This has been bugging me as well, so I cooked up this patch that seems to fix it. It breaks lots of tests though that need fixing as well. Mihai do you have any less invasive ideas?

Comment 3

[Teddy Ni]

In my opinion, preserving spaces in the debug console is the right thing to do. Easily formatted debug strings can make output more useful and palatable. Sure, it's not really important, but I can't think of any down side.

Along the lines of Panos's patch, would it be easier just to change

    aBody = aBody instanceof Ci.nsIDOMNode ?
            aBody : aDocument.createTextNode(aBody);

to

    aBody = aBody instanceof Ci.nsIDOMNode ?
            aBody : aDocument.createTextNode(aBody.replace(/ /g, "\xa0"));

In my inexperience, I have no idea how this would affect any tests.

Comment 4

[Mihai Sucan [:msucan]]

Comment on attachment 540050 [details] [diff] [review]
Patch v1

There must be a styling-based approach. Maybe:

https://developer.mozilla.org/en/CSS/white-space

Try white-space: pre-wrap to see if it works.

Comment 5

[Panos Astithas (he/him) [:past] (please ni?)]

Attachment: Patch v2

Bingo! Works as advertised, thanks!

Comment 6

[Mihai Sucan [:msucan]]

Comment on attachment 540440 [details] [diff] [review]
Patch v2

Great to see it works!

Comment 7

[Panos Astithas (he/him) [:past] (please ni?)]

Comment on attachment 540440 [details] [diff] [review]
Patch v2

Thanks Mihai! Requesting peer review from dao.

Comment 8

[:Gavin Sharp [email: [e-mail]]]

It's somewhat arguable whether that kind of rule belongs in the theme. Does the webConsole have a content stylesheet?

Comment 9

[Dão Gottwald [:dao]]

Comment on attachment 540440 [details] [diff] [review]
Patch v2

This belongs in content CSS. Unfortunately, the webconsole is mingled in the browser window's DOM rather than being a separate iframe.

Comment 10

[Panos Astithas (he/him) [:past] (please ni?)]

Attachment: Patch v3

I wasn't aware of the distinction, thanks. I guess that browser.css is the proper place, then?

Comment 11

[Dão Gottwald [:dao]]

Well, no, ideally there would be a webConsole.css somewhere in toolkit/components/console/, and ideally that stylesheet would be loaded in an iframe rather than browser.xul.

Comment 12

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 540707 [details] [diff] [review]
Patch v3

Indeed, this isn't really the proper place, but there are several things about the current web console code that aren't "proper". You could add a note to bug 635359, and also reference it in a comment here, but maybe it'd be cleaner to just add it to the theme for now and fix everything in bug 635359 (rather than expanding the set of things that need cleaning up to include browser.css).

Comment 13

[Dão Gottwald [:dao]]

Comment on attachment 540440 [details] [diff] [review]
Patch v2

I'm still waiting for cleanup from the early days of the "heads up display" :/

Comment 14

[Panos Astithas (he/him) [:past] (please ni?)]

Thank you both. I added a comment to bug 635359 referencing comment 11 here.

Comment 15

[Rob Campbell [:rc] (:robcee)]

Comment on attachment 540440 [details] [diff] [review]
Patch v2

http://hg.mozilla.org/projects/devtools/rev/fb02b664d02d

Comment 16

[Rob Campbell [:rc] (:robcee)]

backed out to try to clear some orange:

http://hg.mozilla.org/projects/devtools/rev/9d2571f091aa

should be able to reland.

Comment 17

[Rob Campbell [:rc] (:robcee)]

http://hg.mozilla.org/projects/devtools/rev/674f0bd87a13

http://hg.mozilla.org/mozilla-central/rev/674f0bd87a13

Comment 18

[George Carstoiu]

Mozilla/5.0 (X11; Linux i686; rv:7.0a1) Gecko/20110627 Firefox/7.0a1

Verified issue on Ubuntu 11.04, Mac OS X 10.6, WinXP, Win7 using the steps to reproduce from Comment 0.

Setting status to Verified Fixed.