664831 - disable tp4

Status: RESOLVED FIXED

(Release Engineering :: General, defect, P2)

Description

[Armen [:armenzg]]

We are aiming to disable tp4 by June 30th, 2011 on every branch except older release branches. Right now, tp4 & tp5 are running side by side.

Let's use this bug to track the work and make it clear for others.

I will bring this item on the Tuesday meetings until then and ask for anode's OK before doing so.

Comment 1

[Armen [:armenzg]]

The date is just 2 weeks from now but it can be adjusted if there are blockers or we feel we don't have to wait the 2 weeks.

Comment 2

[John O'Duinn [:joduinn] (please use "needinfo?" flag)]

per email with alice, we do *not* need a downtime/treeclosure for disabling tp4.

Comment 3

[Armen [:armenzg]]

Announced yesterday on developer's meeting and on dev.planning and dev.tree-management.

We are still on schedule for June 30th.

Comment 4

[Armen [:armenzg]]

FTR we had to fix several small infra changes outside of releng:
* add tp5 to perf.snarkfest.net [1]
* add tp5 to tbpl's compare feature [2]
* change tp4 to tp on Try Chooser website's [3]

Remaining work:
* disable tp4 (this bug)
* remove tp4 from tbpl's compare feature once disabled on buildbot [4]

[1] https://bitbucket.org/mconnor/compare-talos/changeset/db884c7f8c25
[2] bug 666711
[3] http://hg.mozilla.org/users/lsblakk_mozilla.com/trychooser/rev/639ee77ced36
[4] bug 666952

Comment 5

[Armen [:armenzg]]

Attachment: disable tp4

Getting ready for this Thursday.

Comment 6

[alice nodelman [:alice] [:anode]]

Comment on attachment 542175 [details] [diff] [review]
disable tp4

We may want to keep around the combined tp4/tp5 test, as we still have to get that rolled out to all branches (we still have branches that have not done the side-by-side running to create a viable baseline).  Might be better to create a TALOS_TP5_OPTS and a tp5_tests.

Comment 7

[Armen [:armenzg]]

One thing you might have not noticed is that we have been running tp4/tp5 side by side on all branches! Not just mozilla-central & tracemonkey :)

Comment 8

[Armen [:armenzg]]

This was again announced at the platform meeting without any objections.

anode, gentle poke wrt to review.

Comment 9

[alice nodelman [:alice] [:anode]]

Comment on attachment 542175 [details] [diff] [review]
disable tp4

Looks like tp4 would still be running on:
BRANCHES['mozilla-2.0']['tp4_tests'] = (1, True, TALOS_TP4_OPTS, ALL_PLATFORMS)
BRANCHES['mozilla-2.1']['tp4_tests'] = (1, True, TALOS_TP4_OPTS, ALL_PLATFORMS)
BRANCHES['mozilla-1.9.1']['tp4_tests'] = (1, True, TALOS_TP4_OPTS, OLD_BRANCH_ALL_PLATFORMS)
BRANCHES['mozilla-1.9.2']['tp4_tests'] = (1, True, TALOS_TP4_OPTS, OLD_BRANCH_ALL_PLATFORMS)

I thought that this was to totally be done with tp4?

If we are truly killing tp4 then we should get rid of it, including 

TALOS_TP4_OPTS = {'plugins': 'zips/plugins.zip', 'pagesets': ['zips/tp4.zip',]}

    'tp4': GRAPH_CONFIG + ['--activeTests', 'tp4'],


and lines like:

BRANCHES['mozilla-central']['tp4_tests'] = (0, True, TALOS_TP4_OPTS, ALL_PLATFORMS)

Also, I'd prefer
+TALOS_TP_OPTS = {'plugins': 'zips/plugins.zip', 'pagesets': ['zips/tp5.zip']}
to be
+TALOS_TP_OPTS = {'plugins': 'zips/plugins.zip', 'pagesets': ['zips/tp5.zip',]}

Python can deal with lists in interesting ways, including interpreting a list of a single string entry into a list of individual characters in the string.  The comma forces the interpretation that we want.

Comment 10

[Armen [:armenzg]]

Comment on attachment 542175 [details] [diff] [review]
disable tp4

The plan is to leave tp4 running for older releases branches (1.9.1/1.9.2/2.0/2.1)

I believe the comma problem only happens when dealing with tuples but sure we can take it.

In the light of what I replied can I please have the r+?

Comment 11

[Chris AtLee [:catlee]]

> Python can deal with lists in interesting ways, including interpreting a
> list of a single string entry into a list of individual characters in the
> string.  The comma forces the interpretation that we want.

Armen is correct, this only applies to tuples.

("foo") is the same as "foo"
["foo"] is ["foo"]

Comment 12

[Armen [:armenzg]]

Comment on attachment 542175 [details] [diff] [review]
disable tp4

Checked-in on default:
http://hg.mozilla.org/build/buildbot-configs/rev/a40950c22d89
It will be picked up in today's reconfig.

I have left the try server enabled since roc is figuring out a regression on tp4.

Comment 13

[Chris AtLee [:catlee]]

Attachment: actually disable tp4

I think we need this to actually stop running tp4.

Comment 14

[Armen [:armenzg]]

Comment on attachment 543329 [details] [diff] [review]
actually disable tp4

Landed and reconfiguring:
http://hg.mozilla.org/build/buildbot-configs/rev/407887e1683c