664834 - Switch suite/mailnews to use Services.io

Status: RESOLVED FIXED

(SeaMonkey :: MailNews: General, defect)

Description

[Ian Neal]

Attachment: suite mailnews switch to Services.io

At the moment we have Services.jsm imported but we're not making full use of it.
This patch:
* Switches, where possible, to using Services.io

Comment 1

[[e-mail]]

Comment on attachment 539889 [details] [diff] [review]
suite mailnews switch to Services.io

> function CheckOnline()
> {
>-  var ioService = Components.classes["@mozilla.org/network/io-service;1"]
>-                         .getService(Components.interfaces.nsIIOService);
>-  return (!ioService.offline);
>+  return (!Services.io.offline);
Is it worth replacing CheckOnline completely? Also, don't need the ()s.

>         // Lazily create these globals.
>-        if (!gIOService) {
Just because you removed gIOService doesn't mean you should create gFileHandler and gProfileDirURL every time!

>-          var profileDir = Components.classes["@mozilla.org/file/directory_service;1"]
>-                                     .getService(Components.interfaces.nsIProperties)
[Are you planning to change this to Services.dirsvc at some point?]

Comment 2

[Ian Neal]

Attachment: suite mailnews switch to Services.io and no CheckOnline

Changes since last version:
* Removed CheckOnline function.
* Simplified some code in mailWindowOverlay.js around CheckOnline removal.
* Check if globals exist before creating.

Comment 3

[[e-mail]]

Comment on attachment 540056 [details] [diff] [review]
suite mailnews switch to Services.io and no CheckOnline

>+  if (!Services.io.offline || DoGetNewMailWhenOffline())
This line appears several times. Maybe the offline check belongs inside DoGetNewMailWhenOffline() ;-)

Comment 4

[Ian Neal]

Attachment: suite mailnews switch to Services.io and revised DoGetNewMailWhenOffline

Changes since last version:
* Added a check on !Services.io.offline to DoGetNewMailWhenOffline
* Removed, where applicable, !Services.io.offline check.

Comment 5

[Ian Neal]

Attachment: suite mailnews switch to Services.io and revised DoGetNewMailWhenOffline v2 [Checked in: Comment 7]

Changes since last version:
* If statement changes in mailWindow.js didn't work on second looks, so keeping to a simple change.

Comment 6

[[e-mail]]

Comment on attachment 540225 [details] [diff] [review]
suite mailnews switch to Services.io and revised DoGetNewMailWhenOffline v2 [Checked in: Comment 7]

>+        return (IsFolderSelected() && !Services.io.offline &&
>+                GetNumSelectedMessages() > 0);
Nit: could probably drop the outer set of ()s.

Comment 7

[Ian Neal]

Comment on attachment 540225 [details] [diff] [review]
suite mailnews switch to Services.io and revised DoGetNewMailWhenOffline v2 [Checked in: Comment 7]

http://hg.mozilla.org/comm-central/rev/8f52a70cb585