Closed Bug 664839 Opened 11 years ago Closed 11 years ago

Switch suite/mailnews to use new GetLocalizedPrefString helper

Categories

(SeaMonkey :: MailNews: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
seamonkey2.4

People

(Reporter: iannbugzilla, Assigned: iannbugzilla)

References

Details

Attachments

(1 file)

There are various bits of code in suite/mailnews that could make use of the new GetLocalizedPrefString helper.
This patch:
* Switches code to use GetLocalizedPrefString
* Simplifies some surrounding code where possible.

One more possible simplification could be in tabmail.js' ShowAccountCentral function where we could remove the try/catch.
Attachment #539896 - Flags: review?(neil)
Comment on attachment 539896 [details] [diff] [review]
Switch suite mailnews to use new GetLocalizedStringPref helper [Checked in: Comment 3]

>+  if (GetLocalizedPrefString("mail.addr_book.show_phonetic_fields") == "true")
>     document.getElementById("cmd_SortBy_PhoneticName")
>             .setAttribute("hidden", "false");
Bah, if only the hidden attribute matched the pref string value :-(
Attachment #539896 - Flags: review?(neil) → review+
(In reply to comment #0)
> One more possible simplification could be in tabmail.js' ShowAccountCentral
> function where we could remove the try/catch.
Fair enough. (Sorry, I hadn't read comment #0 before reviewing the patch.)
Comment on attachment 539896 [details] [diff] [review]
Switch suite mailnews to use new GetLocalizedStringPref helper [Checked in: Comment 3]

http://hg.mozilla.org/comm-central/rev/6a9dc33c7bc3
Attachment #539896 - Attachment description: Switch suite mailnews to use new GetLocalizedStringPref helper → Switch suite mailnews to use new GetLocalizedStringPref helper [Checked in: Comment 3]
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.4
Depends on: 677457
You need to log in before you can comment on or make changes to this bug.