664839 - Switch suite/mailnews to use new GetLocalizedPrefString helper

Status: RESOLVED FIXED

(SeaMonkey :: MailNews: General, defect)

Description

[Ian Neal]

Attachment: Switch suite mailnews to use new GetLocalizedStringPref helper [Checked in: Comment 3]

There are various bits of code in suite/mailnews that could make use of the new GetLocalizedPrefString helper.
This patch:
* Switches code to use GetLocalizedPrefString
* Simplifies some surrounding code where possible.

One more possible simplification could be in tabmail.js' ShowAccountCentral function where we could remove the try/catch.

Comment 1

[[e-mail]]

Comment on attachment 539896 [details] [diff] [review]
Switch suite mailnews to use new GetLocalizedStringPref helper [Checked in: Comment 3]

>+  if (GetLocalizedPrefString("mail.addr_book.show_phonetic_fields") == "true")
>     document.getElementById("cmd_SortBy_PhoneticName")
>             .setAttribute("hidden", "false");
Bah, if only the hidden attribute matched the pref string value :-(

Comment 2

[[e-mail]]

(In reply to comment #0)
> One more possible simplification could be in tabmail.js' ShowAccountCentral
> function where we could remove the try/catch.
Fair enough. (Sorry, I hadn't read comment #0 before reviewing the patch.)

Comment 3

[Ian Neal]

Comment on attachment 539896 [details] [diff] [review]
Switch suite mailnews to use new GetLocalizedStringPref helper [Checked in: Comment 3]

http://hg.mozilla.org/comm-central/rev/6a9dc33c7bc3