Cleanup startup cache api

RESOLVED FIXED in mozilla8

Status

()

Core
XPCOM
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: mwu, Assigned: mwu)

Tracking

Trunk
mozilla8
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [inbound])

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
From taras in bug 592943:

This kind of unrelated to the patch. But while you are at this can you get rid of NS_* prefix in this file? and Get rid of the using namespace mozilla::scache(didn't realize it was in a header too :( ) in mozJSComponentLoader?

also rename scache->startupcache and make all calls via the namespace ie

startupcache::PathifyURI.
(Assignee)

Comment 1

6 years ago
Created attachment 546708 [details] [diff] [review]
Kill NS_ prefix, move using out of header

This implements the first two suggestions. I'm a bit suspicious of doing scache->startupcache since that's pretty verbose and requiring the namespace every time makes it even worse. Lines like:

StartupCache* cache = StartupCache::GetSingleton();

would turn into 

startupcache::StartupCache* cache = startupcache::StartupCache::GetSingleton();

Though I think just doing scache->startupcache without removing the use of using would be ok.
Attachment #546708 - Flags: review?(tglek)

Updated

6 years ago
Attachment #546708 - Flags: review?(tglek) → review+
(Assignee)

Comment 2

6 years ago
http://hg.mozilla.org/integration/mozilla-inbound/rev/a9f847216e1f
Whiteboard: [inbound]
http://hg.mozilla.org/mozilla-central/rev/a9f847216e1f
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla8
You need to log in before you can comment on or make changes to this bug.