664924 - Remove MOZ_CSS_ANIMATIONS ifdefs

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

CSS animations stuck; we should remove the backout infrastructure.

Comment 1

[Matheus Kerschbaum]

I probably should have commented here, but I already have a patch for this.

Comment 2

[Matheus Kerschbaum]

Attachment: patch

Comment 3

[Ed Morley [:emorley]]

Oh... I'd been working on this since setting the assignee, oh well it happens :-)

Comment 4

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Hmmm.  I had hoped this would look like a straight backout of
https://hg.mozilla.org/mozilla-central/rev/5f6f0204b682
but it appears to leave a bunch of the ordering wrong.  I suspect that many parts of that patch will still reverse-apply cleanly, though, so it should be straightforward to revert it (and perhaps even more straightforward to backout and hg merge, and then perhaps diff rather than committing the backout).

Comment 5

[Matheus Kerschbaum]

Attachment: patch

Done.

Comment 6

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Attachment: patch

That isn't quite right either, since it isn't merged to the trunk.

Here's the result of a backout and merge, adjusted for the new changes (nsICSSRule.h -> Rule.h and the added code in nsStyleSet.cpp).

This is actually a lot more similar to the first patch than the second, since the second wasn't relative to current trunk.

Comment 7

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

http://hg.mozilla.org/integration/mozilla-inbound/rev/9d70431e1ac5

Comment 8

[(no longer active)]

http://hg.mozilla.org/mozilla-central/rev/9d70431e1ac5