Closed Bug 664924 Opened 8 years ago Closed 8 years ago

Remove MOZ_CSS_ANIMATIONS ifdefs

Categories

(Core :: CSS Parsing and Computation, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla7

People

(Reporter: khuey, Assigned: matjk7)

References

()

Details

Attachments

(1 file, 2 obsolete files)

CSS animations stuck; we should remove the backout infrastructure.
Assignee: nobody → bmo
Status: NEW → ASSIGNED
Flags: in-testsuite-
Version: unspecified → Trunk
I probably should have commented here, but I already have a patch for this.
Attached patch patch (obsolete) — Splinter Review
Attachment #540174 - Flags: review?(dbaron)
Oh... I'd been working on this since setting the assignee, oh well it happens :-)
Assignee: bmo → matjk7
Hmmm.  I had hoped this would look like a straight backout of
https://hg.mozilla.org/mozilla-central/rev/5f6f0204b682
but it appears to leave a bunch of the ordering wrong.  I suspect that many parts of that patch will still reverse-apply cleanly, though, so it should be straightforward to revert it (and perhaps even more straightforward to backout and hg merge, and then perhaps diff rather than committing the backout).
Attached patch patch (obsolete) — Splinter Review
Done.
Attachment #540174 - Attachment is obsolete: true
Attachment #540174 - Flags: review?(dbaron)
Attachment #540182 - Flags: review?(dbaron)
Attached patch patchSplinter Review
That isn't quite right either, since it isn't merged to the trunk.

Here's the result of a backout and merge, adjusted for the new changes (nsICSSRule.h -> Rule.h and the added code in nsStyleSet.cpp).

This is actually a lot more similar to the first patch than the second, since the second wasn't relative to current trunk.
Attachment #540182 - Attachment is obsolete: true
Attachment #540182 - Flags: review?(dbaron)
http://hg.mozilla.org/mozilla-central/rev/9d70431e1ac5
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla7
You need to log in before you can comment on or make changes to this bug.