Closed
Bug 664955
Opened 14 years ago
Closed 14 years ago
"ASSERTION: parser should have rejected negative length"
Categories
(Core :: CSS Parsing and Computation, defect)
Tracking
()
RESOLVED
FIXED
mozilla7
People
(Reporter: jruderman, Assigned: arno)
References
Details
(Keywords: assertion, testcase)
Attachments
(2 files, 3 obsolete files)
|
163 bytes,
text/html
|
Details | |
|
6.41 KB,
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
###!!! ASSERTION: FindNextLargerFontSize failed: '*aSize > parentSize', file layout/style/nsRuleNode.cpp, line 2538
(bug 427322)
###!!! ASSERTION: parser should have rejected negative length: 'widthValue.IsCalcUnit()', file layout/style/nsRuleNode.cpp, line 6283
|
Assignee | |
Comment 1•14 years ago
|
||
This is because nsStyleUtil::FindNextLargerFontSize returns a negative value (because of PRInt32 overflow).
Maybe it can be fixed by checking that returned value is positive (and also, below or equal nscoord_MAX).
|
|
Assignee | |
Updated•14 years ago
|
Attachment #540231 -
Flags: review?(bzbarsky)
|
||
Comment 2•14 years ago
|
||
Comment on attachment 540231 [details] [diff] [review]
patch v1
Should FindNextLargerFontSize be using the saturating computation functions?
|
|
Assignee | |
Comment 3•14 years ago
|
||
Attachment #540231 -
Attachment is obsolete: true
Attachment #540231 -
Flags: review?(bzbarsky)
Attachment #543231 -
Flags: review?(bzbarsky)
|
|
Assignee | |
Comment 5•14 years ago
|
||
Sorry, wrong file attached. I should have checked more.
Attachment #543231 -
Attachment is obsolete: true
Attachment #543231 -
Flags: review?(bzbarsky)
Attachment #543266 -
Flags: review?(bzbarsky)
|
|
||
Comment 6•14 years ago
|
||
>+ largerSize = indexFontSize + NSCoordSaturatingNonnegativeMultiply(largerIndexFontSize - indexFontSize, relativePosition);
Should that be a saturating add?
|
|
Assignee | |
Comment 7•14 years ago
|
||
Attachment #543266 -
Attachment is obsolete: true
Attachment #543266 -
Flags: review?(bzbarsky)
Attachment #543360 -
Flags: review?(bzbarsky)
|
|
||
Comment 8•14 years ago
|
||
Comment on attachment 543360 [details] [diff] [review]
patch v2.1
r=me. Thank you!
Attachment #543360 -
Flags: review?(bzbarsky) → review+
|
|
Assignee | |
Updated•14 years ago
|
Keywords: checkin-needed
|
||
Comment 9•14 years ago
|
||
Assignee: nobody → arno
Status: NEW → RESOLVED
Closed: 14 years ago
Flags: in-testsuite+
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla7
You need to log in
before you can comment on or make changes to this bug.
Description
•