The default bug view has changed. See this FAQ.

xpfe should use mozilla::Preferences

RESOLVED FIXED in mozilla7

Status

()

Core
XP Toolkit/Widgets: XUL
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: masayuki, Assigned: masayuki)

Tracking

Trunk
mozilla7
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Created attachment 540022 [details] [diff] [review]
Patch v1.0
Attachment #540022 - Flags: review?(neil)

Comment 1

6 years ago
Comment on attachment 540022 [details] [diff] [review]
Patch v1.0

>+  if (!Preferences::GetRootBranch()) {
>+    return NS_ERROR_FAILURE;
>+  }
Don't need this, Preferences::GetInt null-checks sPreferences.
r=me with that fixed.

>+  rv = Preferences::GetInt("network.dir.format", &dirPref);
>   if (NS_SUCCEEDED(rv) && dirPref == FORMAT_XUL) {
In fact, you could probably simplify this to
if (Preferences::GetInt("network.dir.format") == FORMAT_XUL)
Attachment #540022 - Flags: review?(neil) → review+
(Assignee)

Comment 2

6 years ago
http://hg.mozilla.org/integration/mozilla-inbound/rev/1653c994c505
Whiteboard: [inbound]
Merged:
http://hg.mozilla.org/mozilla-central/rev/1653c994c505
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Whiteboard: [inbound]
Target Milestone: --- → mozilla7
You need to log in before you can comment on or make changes to this bug.