Closed Bug 664969 Opened 12 years ago Closed 12 years ago

xpfe should use mozilla::Preferences

Categories

(Core :: XUL, defect)

Product:
Core
Component:
XUL
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla7

People

(Reporter: masayuki, Assigned: masayuki)

References

Details

Attachments

(1 file)

Patch v1.0
10.05 KB, patch
neil
: review+
Details | Diff | Splinter Review
Attached patch Patch v1.0 — — Splinter Review 
      No description provided.
Attachment #540022 - Flags: review?(neil)
Comment on attachment 540022 [details] [diff] [review]
Patch v1.0

>+  if (!Preferences::GetRootBranch()) {
>+    return NS_ERROR_FAILURE;
>+  }
Don't need this, Preferences::GetInt null-checks sPreferences.
r=me with that fixed.

>+  rv = Preferences::GetInt("network.dir.format", &dirPref);
>   if (NS_SUCCEEDED(rv) && dirPref == FORMAT_XUL) {
In fact, you could probably simplify this to
if (Preferences::GetInt("network.dir.format") == FORMAT_XUL)
Attachment #540022 - Flags: review?(neil) → review+
Merged:
http://hg.mozilla.org/mozilla-central/rev/1653c994c505
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Whiteboard: [inbound]
Target Milestone: --- → mozilla7
Moving to Core:XUL per https://bugzilla.mozilla.org/show_bug.cgi?id=1455336
Component: XP Toolkit/Widgets: XUL → XUL
You need to log in before you can comment on or make changes to this bug.