The default bug view has changed. See this FAQ.

Plugin Stack Overflow Crash [@ _SEH_prolog ]

VERIFIED FIXED in mozilla7

Status

()

Core
Plug-ins
--
critical
VERIFIED FIXED
6 years ago
2 years ago

People

(Reporter: bc, Assigned: jimm)

Tracking

(Blocks: 1 bug, {crash, reproducible})

Trunk
mozilla7
x86
Windows XP
crash, reproducible
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(crash signature, URL)

Attachments

(1 attachment)

(Reporter)

Description

6 years ago
1. http://www.filimizle.org/category/turkce-dublaj-filmler/page/2
2. Crash stack overflow

bp-12d560a4-9541-4283-bb0d-6e9882110617

0 	user32.dll 	_SEH_prolog 	
1 	user32.dll 	CallWindowProcAorW 	
2 	user32.dll 	CallWindowProcW 	
3 	xul.dll 	mozilla::plugins::PluginInstanceParent::PluginWindowHookProc 	dom/plugins/ipc/PluginInstanceParent.cpp:1601
4 	user32.dll 	InternalCallWinProc 	
5 	user32.dll 	UserCallWinProcCheckWow 	
6 	user32.dll 	CallWindowProcAorW 	
7 	user32.dll 	CallWindowProcW 	
8 	xul.dll 	mozilla::plugins::PluginInstanceParent::PluginWindowHookProc 	dom/plugins/ipc/PluginInstanceParent.cpp:1601
(Reporter)

Comment 1

6 years ago
1.9.2 bp-c5e0a704-610d-4199-a65a-e9d112110617
Assignee: nobody → jmathies
(Assignee)

Updated

6 years ago
Blocks: 665371
(Assignee)

Comment 2

6 years ago
Benjamin, I think we might want to add this frame to the skip list - 

https://crash-stats.mozilla.com/report/list?product=Firefox&version=Firefox%3A5.0&platform=windows&query_search=signature&query_type=contains&query=_SEH_prolog&reason_type=contains&date=06%2F23%2F2011%2009%3A53%3A12&range_value=1&range_unit=weeks&hang_type=any&process_type=any&do_query=1&signature=_SEH_prolog

This catches a whole host of unrelated crashes.
(Assignee)

Comment 3

6 years ago
Multiple shockwave instances seem to be the cause of this. We set mPluginWndProc on a set window call by subclassing in PluginInstanceParent, the result of the subclass returns PluginInstanceParent's PluginWindowHookProc. How we get into this state isn't entirely clear, but I have a patch that keeps us from crashing in these cases.
(Assignee)

Comment 4

6 years ago
Created attachment 541449 [details] [diff] [review]
fix
Attachment #541449 - Flags: review?(benjamin)
Comment on attachment 541449 [details] [diff] [review]
fix

Blech.
Attachment #541449 - Flags: review?(benjamin) → review+
(Assignee)

Comment 6

6 years ago
http://hg.mozilla.org/integration/mozilla-inbound/rev/8f196152e8d8
http://hg.mozilla.org/mozilla-central/rev/8f196152e8d8
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla7
(Reporter)

Comment 8

6 years ago
I can no longer reproduce these crashes on Nightly or Aurora. Verifying.
Status: RESOLVED → VERIFIED
Keywords: testcase-wanted
You need to log in before you can comment on or make changes to this bug.