Last Comment Bug 664974 - Plugin Stack Overflow Crash [@ _SEH_prolog ]
: Plugin Stack Overflow Crash [@ _SEH_prolog ]
Status: VERIFIED FIXED
: crash, reproducible
Product: Core
Classification: Components
Component: Plug-ins (show other bugs)
: Trunk
: x86 Windows XP
: -- critical (vote)
: mozilla7
Assigned To: Jim Mathies [:jimm]
:
: Benjamin Smedberg [:bsmedberg]
Mentors:
http://www.filimizle.org/category...
Depends on:
Blocks: 532972 665371
  Show dependency treegraph
 
Reported: 2011-06-17 04:36 PDT by Bob Clary [:bc:]
Modified: 2015-10-16 11:47 PDT (History)
3 users (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
fix (902 bytes, patch)
2011-06-23 11:50 PDT, Jim Mathies [:jimm]
benjamin: review+
Details | Diff | Splinter Review

Description Bob Clary [:bc:] 2011-06-17 04:36:14 PDT
1. http://www.filimizle.org/category/turkce-dublaj-filmler/page/2
2. Crash stack overflow

bp-12d560a4-9541-4283-bb0d-6e9882110617

0 	user32.dll 	_SEH_prolog 	
1 	user32.dll 	CallWindowProcAorW 	
2 	user32.dll 	CallWindowProcW 	
3 	xul.dll 	mozilla::plugins::PluginInstanceParent::PluginWindowHookProc 	dom/plugins/ipc/PluginInstanceParent.cpp:1601
4 	user32.dll 	InternalCallWinProc 	
5 	user32.dll 	UserCallWinProcCheckWow 	
6 	user32.dll 	CallWindowProcAorW 	
7 	user32.dll 	CallWindowProcW 	
8 	xul.dll 	mozilla::plugins::PluginInstanceParent::PluginWindowHookProc 	dom/plugins/ipc/PluginInstanceParent.cpp:1601
Comment 1 Bob Clary [:bc:] 2011-06-17 04:46:44 PDT
1.9.2 bp-c5e0a704-610d-4199-a65a-e9d112110617
Comment 3 Jim Mathies [:jimm] 2011-06-23 11:48:18 PDT
Multiple shockwave instances seem to be the cause of this. We set mPluginWndProc on a set window call by subclassing in PluginInstanceParent, the result of the subclass returns PluginInstanceParent's PluginWindowHookProc. How we get into this state isn't entirely clear, but I have a patch that keeps us from crashing in these cases.
Comment 4 Jim Mathies [:jimm] 2011-06-23 11:50:44 PDT
Created attachment 541449 [details] [diff] [review]
fix
Comment 5 Benjamin Smedberg [:bsmedberg] 2011-06-23 14:25:42 PDT
Comment on attachment 541449 [details] [diff] [review]
fix

Blech.
Comment 7 Marco Bonardo [::mak] 2011-06-24 02:55:34 PDT
http://hg.mozilla.org/mozilla-central/rev/8f196152e8d8
Comment 8 Bob Clary [:bc:] 2011-08-09 16:25:20 PDT
I can no longer reproduce these crashes on Nightly or Aurora. Verifying.

Note You need to log in before you can comment on or make changes to this bug.