664986 - Fix random timeouts in livemarks tests

Status: RESOLVED FIXED

(Toolkit :: Places, defect)

Description

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

From some logging I got on try it seems to be caused by idle, when the user is idle from more than 30 minutes we stop updating livemarks, sometimes the tinderboxes are idle from more than 30 minutes and livemarks tests timeout.
This patch makes sure tests use forceUpdate APIs rather than the common start() call, and fixes reloadAllLivemarks to use the lazy loading stuff rather than a simple loop so I can use it instead of start() in tests (there is another bug about the fact reloadAllLivemarks hangs everything for minutes, so this may even fix that).

Comment 1

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Attachment: patch

Notice this is blocking next Places merge since currently tree has orange due to this

Comment 2

[Dietrich Ayala (:dietrich)]

Comment on attachment 540049 [details] [diff] [review]
patch

Review of attachment 540049 [details] [diff] [review]:
-----------------------------------------------------------------

looks fine, r=me

Comment 3

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

http://hg.mozilla.org/projects/places/rev/6604c07b0de4

Comment 4

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

http://hg.mozilla.org/mozilla-central/rev/6604c07b0de4