Closed
Bug 664986
Opened 14 years ago
Closed 14 years ago
Fix random timeouts in livemarks tests
Categories
(Toolkit :: Places, defect)
Toolkit
Places
Tracking
()
RESOLVED
FIXED
mozilla7
People
(Reporter: mak, Assigned: mak)
References
Details
(Whiteboard: [fixed-in-places])
Attachments
(1 file)
|
5.51 KB,
patch
|
dietrich
:
review+
|
Details | Diff | Splinter Review |
From some logging I got on try it seems to be caused by idle, when the user is idle from more than 30 minutes we stop updating livemarks, sometimes the tinderboxes are idle from more than 30 minutes and livemarks tests timeout.
This patch makes sure tests use forceUpdate APIs rather than the common start() call, and fixes reloadAllLivemarks to use the lazy loading stuff rather than a simple loop so I can use it instead of start() in tests (there is another bug about the fact reloadAllLivemarks hangs everything for minutes, so this may even fix that).
|
Assignee | |
Comment 1•14 years ago
|
||
Notice this is blocking next Places merge since currently tree has orange due to this
Attachment #540049 -
Flags: review?(dietrich)
|
||
Comment 2•14 years ago
|
||
Comment on attachment 540049 [details] [diff] [review]
patch
Review of attachment 540049 [details] [diff] [review]:
-----------------------------------------------------------------
looks fine, r=me
Attachment #540049 -
Flags: review?(dietrich) → review+
|
|
Assignee | |
Comment 3•14 years ago
|
||
Whiteboard: [fixed-in-places]
|
|
Assignee | |
Comment 4•14 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla7
You need to log in
before you can comment on or make changes to this bug.
Description
•