664992 - Can no longer suppress unsortedBookmarks entry in the Bookmarks Menu

Status: RESOLVED INVALID

(Firefox :: Bookmarks & History, defect)

Description

[Marc Auslander]

User-Agent:       Mozilla/5.0 (Windows NT 5.1; rv:6.0a2) Gecko/20110615 Firefox/6.0a2
Build Identifier: Mozilla/5.0 (Windows NT 5.1; rv:6.0a2) Gecko/20110615 Firefox/6.0a2

Up through Firefox 5 beta, you could simply move the unsortedBookmarks menu entry someplace else.  As of aurora, it copies but stays in the bookmarkMenu.

I've tried the published "fix":

/* Do not remove the @namespace line -- it's required for correct functioning */
@namespace url("http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul");
#BMB_unsortedBookmarks {display: none !important;} 

and this has no effect in aurora.




Reproducible: Always

Steps to Reproduce:
1. See above
2.
3.

Actual Results:  
unsorted Bookmarks entry at bottom of bookmarks menu

Expected Results:  
unsorted Bookmarks entry hidden

I've looked at the xul and nothing has changed.

Comment 1

[Simona Badau, Desktop QA]

Mozilla/5.0 (Windows NT 5.1; rv:7.0a1) Gecko/20110619 Firefox/7.0a1

Reporter, can you please provide more clear steps to reproduce?

Comment 2

[Marc Auslander]

Create an empty Aurora profile.
Open Aurora, click on bookmarks, and you see unsorted Bookmarks at the bottom of the menu.
Close Aurora.
go to the profile directory.  make a chrome subdirectory.  create, in the chrome subdirectory, a userChrome.css file containing:

/* Do not remove the @namespace line -- it's required for correct functioning */
@namespace url("http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul");
#BMB_unsortedBookmarks {display: none !important;} 

Open aurora again. open the bookmarks menu.  unsorted Bookmarks is still there.

Comment 3

[Chris Ross]

Hi

Try 
#BMB_unsortedBookmarksFolderMenu
 {
  display: none !important 
 }

Comment 4

[Marc Auslander]

Doesn't work for me.

Comment 5

[Marco Bonardo [:mak]]

the bookmarks button: #BMB_unsortedBookmarksFolderMenu
the bookmarks menu: #menu_unsortedBookmarks
the bookmarks menu in the appmenu: #appmenu_unsortedBookmarks

Comment 6

[Marc Auslander]

#menu_unsortedBookmarks works for me - again - is this stuff documented anyplace?  Or is there code that shows it?

however, the separator is still there under the bookmarks.  I tried 
#menu_unsortedBookmarks+menuseparator and that didn't kill it.

Comment 7

[Marc Auslander]

(Ignorance alert!)

I'm guessing that I can't kill the separator because the separator at:

http://mxr.mozilla.org/mozilla-aurora/source/browser/base/content/browser-menubar.inc#489

doesn't have an id, so I can't name it.

Comment 8

[Marco Bonardo [:mak]]

ehr, #BMB_unsortedBookmarksFolderMenu is instead #BMB_unsortedBookmarks as the other 2.
For the separator, you may try bookmarksMenuPopup > menuseparator[builder="end"], or make a patch to add ids to all three locations.

there is no centralized place for all the ids, you may search mxr like http://mxr.mozilla.org/mozilla-central/search?string=_unsortedBookmarks

Comment 9

[Marc Auslander]

Thanks.

In aurora, the unsorted menu id has changed to menu_unsortedBookmarks and this works.

Your suggestion of bookmarksMenuPopup > menuseparator[builder="end"]

also work to kill the extra separator.  Thanks.