Closed
Bug 664996
Opened 14 years ago
Closed 14 years ago
After quitting the application by tapping the Home button, re-entering it will show a black screen
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(firefox6 fixed, firefox7 fixed, fennec7+)
VERIFIED
FIXED
Firefox 6
People
(Reporter: anamaria.moldovan, Unassigned)
References
Details
(Keywords: regression)
Attachments
(1 file, 1 obsolete file)
2.73 KB,
patch
|
dougt
:
review+
dougt
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
Build ID: Mozilla /5.0 (Android;Linux armv7l;rv:7.0a1) Gecko/20110617 Firefox/7.0a1 Fennec/7.0a1
Device: HTC Desire Z (Android 2.2)
Steps to reproduce:
1. Load Fennec.
2. Tap the Home Button to bring the application in background.
3. Tap the application's icon.
Actual results:
White screen is displayed. Please see the video: http://www.youtube.com/user/qaioana#p/u/0/t-203zqNzOU
Expected results:
The webpage or about:home should be displayed.
Comment 1•14 years ago
|
||
Confirmed, I can see it in today's trunk build, but yesterday's build didn't have this problem.
Keywords: regression
Comment 2•14 years ago
|
||
Also happening when tapping on the 'Back' button while being in the options.
Comment 3•14 years ago
|
||
(In reply to comment #2)
> Also happening when tapping on the 'Back' button while being in the options.
I don't see this part.
I _can_ see the white screen after tapping Home and coming back to the app.
FWIW, tapping on the white screen causes a redraw and all is well again.
Comment 4•14 years ago
|
||
Regression from bug 661843
Comment 5•14 years ago
|
||
(In reply to comment #4)
> Regression from bug 661843
Missed the "?" - That was a question, not a statement
Comment 6•14 years ago
|
||
I think it may be and I have a patch that possibly fixes it, just testing and will attach when it's done (if it does fix it...)
Comment 7•14 years ago
|
||
Because I'd altered the way surface creation works, it was possible to have a null buffer in surfaceChanged while having a valid surface size.
Instead of looking at the buffer pointers, I've replaced it with a boolean that tracks whether the surface size is valid or not. This fixes the issue for me.
Attachment #540059 -
Flags: review?(doug.turner)
Comment 8•14 years ago
|
||
Updated•14 years ago
|
Attachment #540059 -
Flags: review?(doug.turner) → review+
Comment 9•14 years ago
|
||
Status: NEW → RESOLVED
Closed: 14 years ago
Flags: in-testsuite?
Resolution: --- → FIXED
Target Milestone: --- → Firefox 7
Reporter | ||
Comment 10•14 years ago
|
||
Now, after tapping Home and coming back to the app, I can see a black screen. Was the changeset pushed to the pushlog?
Build ID:Mozilla /5.0 (Android;Linux armv7l;rv:7.0a1) Gecko/20110620 Firefox/7.0a1 Fennec/7.0a1
Device: HTC Desire Z (Android 2.2)
Comment 11•14 years ago
|
||
(In reply to comment #10)
> Now, after tapping Home and coming back to the app, I can see a black
> screen. Was the changeset pushed to the pushlog?
I see the same on a Nexus One
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Summary: After quitting the application by tapping the Home button, re-entering it will show a white screen → After quitting the application by tapping the Home button, re-entering it will show a black screen
Comment 12•14 years ago
|
||
Ok, I'll have to test this on my HTC Desire (works for me on the Xoom, but I guess that's quite different).
Updated•14 years ago
|
tracking-fennec: --- → ?
Updated•14 years ago
|
tracking-fennec: ? → 7+
Comment 13•14 years ago
|
||
Not sure what's happened, but I can always reproduce this on my Xoom now... Wondering if something else has changed in the meantime.
Looking at what happens, we create the surface fine, we get the surfaceChanged signal fine and we schedule the redraw fine - but the redraw doesn't happen. Am looking into this...
Comment 14•14 years ago
|
||
Typical, the real cause for this is a typo. Will attach a revised patch in a mo.
Comment 15•14 years ago
|
||
Here's the udpated patch, along with a commit message. The typo was causing the synchronised draw scheduled in surfaceChanged to be ignored, so nothing was being painted at all.
Attachment #540059 -
Attachment is obsolete: true
Attachment #540939 -
Flags: review?(doug.turner)
Updated•14 years ago
|
Attachment #540939 -
Flags: review?(doug.turner) → review+
Comment 16•14 years ago
|
||
Status: REOPENED → RESOLVED
Closed: 14 years ago → 14 years ago
Resolution: --- → FIXED
Comment 17•14 years ago
|
||
Comment on attachment 540939 [details] [diff] [review]
Fix redraw handling on first draw after surfaceChanged
required followup to bug 661843 which is already m-a approved.
Attachment #540939 -
Flags: approval-mozilla-aurora+
Comment 18•14 years ago
|
||
status-firefox7:
--- → fixed
Comment 19•14 years ago
|
||
Verified Fixed
Mozilla/5.0 (Android; Linux; armv7l; rv:7.0a1) Gecko/20110627 FIrefox/7.0a1 Fennec/7.0a1
Status: RESOLVED → VERIFIED
status-firefox6:
--- → fixed
Updated•14 years ago
|
Target Milestone: Firefox 7 → Firefox 6
You need to log in
before you can comment on or make changes to this bug.
Description
•