Closed
Bug 665040
Opened 12 years ago
Closed 12 years ago
find -not is not posix compliant
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: gaston, Unassigned)
Details
(Whiteboard: [fixed-in-tracemonkey])
Attachments
(1 file, 1 obsolete file)
1.28 KB,
patch
|
khuey
:
review+
|
Details | Diff | Splinter Review |
in js/src/Makefile.in, find -not is used, which is a non-posix option. That fails on OpenBSD with 'find : -not : unknown option'. '!' is posix.
Reporter | ||
Comment 1•12 years ago
|
||
Untested... but should be correct, right ?
Attachment #540085 -
Flags: review?(khuey)
Comment on attachment 540085 [details] [diff] [review] Use ! instead of -not to be posix-friendly Looks fine. Push it to tryserver to make sure the builds complete before requesting checkin?
Attachment #540085 -
Flags: review?(khuey) → review+
Reporter | ||
Comment 3•12 years ago
|
||
updated patch, previous one didn't apply. This one replaces two -not occurences. Pushed to try server as http://hg.mozilla.org/try/rev/c848adab43b6
Attachment #540085 -
Attachment is obsolete: true
Attachment #540158 -
Flags: review?(khuey)
Reporter | ||
Comment 4•12 years ago
|
||
http://tbpl.mozilla.org/?tree=Try&rev=c848adab43b6 Builds were correct, but there's been three oranges and a purple..
Reporter | ||
Comment 5•12 years ago
|
||
Not sure about the try results, but setting checkin-needed as the builds themselves were ok
Keywords: checkin-needed
Attachment #540158 -
Flags: review?(khuey) → review+
Comment 6•12 years ago
|
||
(In reply to comment #4) > http://tbpl.mozilla.org/?tree=Try&rev=c848adab43b6 > > Builds were correct, but there's been three oranges and a purple.. Those are nothing to worry about, any errors this brings up would lead to an orange B (this code is run as part of |make check|, which runs after the build in the B section - build errors are red, test errors are orange). I'll push for you in a moment.
Reporter | ||
Comment 7•12 years ago
|
||
(In reply to comment #6) > (In reply to comment #4) > > http://tbpl.mozilla.org/?tree=Try&rev=c848adab43b6 > > > > Builds were correct, but there's been three oranges and a purple.. > > Those are nothing to worry about, any errors this brings up would lead to an > orange B (this code is run as part of |make check|, which runs after the > build in the B section - build errors are red, test errors are orange). Oh i'm aware of all that thanks, but i just wondered if everything had to be really green before adding checkin-needed. > I'll push for you in a moment. Thanks!
Comment 8•12 years ago
|
||
http://hg.mozilla.org/tracemonkey/rev/8c1ddbd41297 (In reply to comment #7) > Oh i'm aware of all that thanks, but i just wondered if everything had to be > really green before adding checkin-needed. Not until the orange factor is low enough: http://brasstacks.mozilla.com/orangefactor/
Keywords: checkin-needed
Whiteboard: [fixed-in-tracemonkey]
Comment 9•12 years ago
|
||
cdleary-bot mozilla-central merge info: http://hg.mozilla.org/mozilla-central/rev/8c1ddbd41297
Updated•12 years ago
|
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•