665040 - find -not is not posix compliant

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Landry Breuil (:gaston)]

in js/src/Makefile.in, find -not is used, which is a non-posix option. That fails on OpenBSD with 'find : -not : unknown option'. '!' is posix.

Comment 1

[Landry Breuil (:gaston)]

Attachment: Use ! instead of -not to be posix-friendly

Untested... but should be correct, right ?

Comment 2

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Comment on attachment 540085 [details] [diff] [review]
Use ! instead of -not to be posix-friendly

Looks fine.  Push it to tryserver to make sure the builds complete before requesting checkin?

Comment 3

[Landry Breuil (:gaston)]

Attachment: find -not is not posix

updated patch, previous one didn't apply. This one replaces two -not occurences.

Pushed to try server as http://hg.mozilla.org/try/rev/c848adab43b6

Comment 4

[Landry Breuil (:gaston)]

http://tbpl.mozilla.org/?tree=Try&rev=c848adab43b6

Builds were correct, but there's been three oranges and a purple..

Comment 5

[Landry Breuil (:gaston)]

Not sure about the try results, but setting checkin-needed as the builds themselves were ok

Comment 6

[Paul Biggar]

(In reply to comment #4)
> http://tbpl.mozilla.org/?tree=Try&rev=c848adab43b6
> 
> Builds were correct, but there's been three oranges and a purple..

Those are nothing to worry about, any errors this brings up would lead to an orange B (this code is run as part of |make check|, which runs after the build in the B section - build errors are red, test errors are orange).

I'll push for you in a moment.

Comment 7

[Landry Breuil (:gaston)]

(In reply to comment #6)
> (In reply to comment #4)
> > http://tbpl.mozilla.org/?tree=Try&rev=c848adab43b6
> > 
> > Builds were correct, but there's been three oranges and a purple..
> 
> Those are nothing to worry about, any errors this brings up would lead to an
> orange B (this code is run as part of |make check|, which runs after the
> build in the B section - build errors are red, test errors are orange).

Oh i'm aware of all that thanks, but i just wondered if everything had to be really green before adding checkin-needed.

> I'll push for you in a moment.

Thanks!

Comment 8

[Paul Biggar]

http://hg.mozilla.org/tracemonkey/rev/8c1ddbd41297



(In reply to comment #7)
> Oh i'm aware of all that thanks, but i just wondered if everything had to be
> really green before adding checkin-needed.

Not until the orange factor is low enough: http://brasstacks.mozilla.com/orangefactor/

Comment 9

[Chris Leary [:cdleary] (not checking bugmail)]

cdleary-bot mozilla-central merge info:
http://hg.mozilla.org/mozilla-central/rev/8c1ddbd41297