hoist JSString and family into vm/String{.h, -inl.h, .cpp}

RESOLVED FIXED

Status

()

Core
JavaScript Engine
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: luke, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: fixed-in-tracemonkey)

Attachments

(1 attachment)

(Reporter)

Description

6 years ago
Created attachment 540138 [details] [diff] [review]
pull into vm/String{.h, -inl.h, .cpp}

As part of bug 653057, this bug is to separate the string representation from all the string natives in jsstr.h/jsstr.cpp.  Simple patch attached.
Attachment #540138 - Flags: review?(nnethercote)
Comment on attachment 540138 [details] [diff] [review]
pull into vm/String{.h, -inl.h, .cpp}

Review of attachment 540138 [details] [diff] [review]:
-----------------------------------------------------------------

r=me on the assumption that you moved the contents of jsstr{.cpp,.h,inlines.h} into String{.cpp,.h,-inl.h} without any changes.
Attachment #540138 - Flags: review?(nnethercote) → review+
(Reporter)

Comment 2

6 years ago
(In reply to comment #1)
> r=me on the assumption that you moved the contents of
> jsstr{.cpp,.h,inlines.h} into String{.cpp,.h,-inl.h} without any changes.

Oops, I should have said that explicitly, but yes it is the case.
(Reporter)

Comment 3

6 years ago
http://hg.mozilla.org/tracemonkey/rev/aa383564c5b6
Whiteboard: fixed-in-tracemonkey
cdleary-bot mozilla-central merge info:
http://hg.mozilla.org/mozilla-central/rev/aa383564c5b6
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.