Closed Bug 665189 Opened 13 years ago Closed 13 years ago

hoist JSString and family into vm/String{.h, -inl.h, .cpp}

Categories

(Core :: JavaScript Engine, defect)

Product:
Core
Component:
JavaScript Engine
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: luke, Unassigned)

References

Details

(Whiteboard: fixed-in-tracemonkey)

Attachments

(1 file)

pull into vm/String{.h, -inl.h, .cpp}
102.91 KB, patch
n.nethercote
: review+
Details | Diff | Splinter Review 
As part of bug 653057, this bug is to separate the string representation from all the string natives in jsstr.h/jsstr.cpp.  Simple patch attached.
Attachment #540138 - Flags: review?(nnethercote)
Comment on attachment 540138 [details] [diff] [review]
pull into vm/String{.h, -inl.h, .cpp}

Review of attachment 540138 [details] [diff] [review]:
-----------------------------------------------------------------

r=me on the assumption that you moved the contents of jsstr{.cpp,.h,inlines.h} into String{.cpp,.h,-inl.h} without any changes.
Attachment #540138 - Flags: review?(nnethercote) → review+
(In reply to comment #1)
> r=me on the assumption that you moved the contents of
> jsstr{.cpp,.h,inlines.h} into String{.cpp,.h,-inl.h} without any changes.

Oops, I should have said that explicitly, but yes it is the case.
http://hg.mozilla.org/tracemonkey/rev/aa383564c5b6
Whiteboard: fixed-in-tracemonkey
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.