Closed Bug 665216 Opened 13 years ago Closed 11 years ago

Helper App Service should accept a filename hint on a channel

Categories

(Core Graveyard :: File Handling, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED INVALID

People

(Reporter: khuey, Assigned: khuey)

References

Details

Attachments

(1 file, 1 obsolete file)

Attached patch Patch (obsolete) — Splinter Review
      No description provided.
Attachment #540171 - Flags: review?(sdwilsh)
Comment on attachment 540171 [details] [diff] [review]
Patch

Review of attachment 540171 [details] [diff] [review]:
-----------------------------------------------------------------

r=sdwilsh
Attachment #540171 - Flags: review?(sdwilsh) → review+
Attached patch PatchSplinter Review
Updated and unbitrotted.
Attachment #540171 - Attachment is obsolete: true
Blocks: 736324
Blocks: 676619
Comment on attachment 606637 [details] [diff] [review]
Patch

Review of attachment 606637 [details] [diff] [review]:
-----------------------------------------------------------------

::: uriloader/exthandler/nsExternalHelperAppService.cpp
@@ +273,5 @@
>    nsresult rv = aChannel->GetContentDisposition(&disp);
>    if (NS_SUCCEEDED(rv))
>    {
> +    if (aFileName.IsEmpty()) {
> +      aChannel->GetContentDispositionFilename(aFileName);

The bug title is misleading, the filename is not really a hint.
Comment on attachment 606637 [details] [diff] [review]
Patch

Use solution in bug 795442 instead of PropertyBag?
Attachment #606637 - Flags: feedback-
This is not needed anymore.
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → INVALID
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: