665216 - Helper App Service should accept a filename hint on a channel

Status: RESOLVED INVALID

(Core Graveyard :: File Handling, defect)

Description

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Attachment: Patch

Comment 1

[Shawn Wilsher :sdwilsh]

Comment on attachment 540171 [details] [diff] [review]
Patch

Review of attachment 540171 [details] [diff] [review]:
-----------------------------------------------------------------

r=sdwilsh

Comment 2

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Attachment: Patch

Updated and unbitrotted.

Comment 3

[Tom S]

Comment on attachment 606637 [details] [diff] [review]
Patch

Review of attachment 606637 [details] [diff] [review]:
-----------------------------------------------------------------

::: uriloader/exthandler/nsExternalHelperAppService.cpp
@@ +273,5 @@
>    nsresult rv = aChannel->GetContentDisposition(&disp);
>    if (NS_SUCCEEDED(rv))
>    {
> +    if (aFileName.IsEmpty()) {
> +      aChannel->GetContentDispositionFilename(aFileName);

The bug title is misleading, the filename is not really a hint.

Comment 4

[Jason Duell]

Comment on attachment 606637 [details] [diff] [review]
Patch

Use solution in bug 795442 instead of PropertyBag?

Comment 5

[Tom S]

This is not needed anymore.