665260 - Store start time in sessionstore data

Status: RESOLVED FIXED

(Firefox :: Session Restore, defect)

Description

[Paul O'Shannessy [:zpao] (not bugmail, email directly)]

I think it could be interesting to have this data for telemetry, even if it doesn't have any practical uses. To be clear, I mean total age, not uptime of current process.

The way we write sessionstore.js, it clobbers the file creation time stamp each write so we can't just extract it.

Dietrich, Taras - does this sound useful?

Comment 1

[(dormant account)]

(In reply to comment #0)
> Dietrich, Taras - does this sound useful?

Yes.

Comment 2

[Paul O'Shannessy [:zpao] (not bugmail, email directly)]

Attachment: Patch v0.1

Does the thing. Due to bug 665702, this data isn't exposed outside of the file.

I tested by checking the timestamp in sessionstore.js like so:

first startup with apptabs (no previous value):
  1308595047885
restart (session not resumed / just app tabs):
  1308595192604
restore previous session:
  1308595047885
  (the start time from previous session overwrites new value)
restart with resume_session_once=true:
  1308595047885
restart with startup.page=3 (aka restore):
  1308595047885

Comment 3

[Dietrich Ayala (:dietrich)]

Comment on attachment 540595 [details] [diff] [review]
Patch v0.1

Review of attachment 540595 [details] [diff] [review]:
-----------------------------------------------------------------

looks a-ok, r=me.

Comment 4

[(no longer active)]

http://hg.mozilla.org/mozilla-central/rev/05b7d31f72bb

Comment 5

[Vlad [QA]]

How can this be verified? 
Thx