Closed
Bug 665280
Opened 14 years ago
Closed 14 years ago
Content script using XPathResult constants fails
Categories
(Add-on SDK Graveyard :: General, defect, P1)
Add-on SDK Graveyard
General
Tracking
(Not tracked)
RESOLVED
FIXED
1.1
People
(Reporter: ochameau, Assigned: ochameau)
Details
Attachments
(1 file)
|
2.60 KB,
patch
|
myk
:
review+
|
Details | Diff | Splinter Review |
Because of a bug on XrayWrappers, all XPathResult's contants end up being undefined on XrayWrappers.
I found this bug thanks to philipp (on #jetpack) that simply tell us that his content script was not working with last 1.0rc.
Here is his failing script:
https://addons.mozilla.org/de/firefox/files/browse/117244/file/resources/jid0-ojclbmln8tobvivhpq2drr2pilu-binnenibegone-data/binnenibegone.user.js#L8
XPathResult.UNORDERED_NODE_SNAPSHOT_TYPE is undefined whereas it should be 6.
I filled a bug on platform side: bug 665279.
| Assignee | ||
Comment 1•14 years ago
|
||
Here is a fix.
Assignee: nobody → poirot.alex
Attachment #540230 -
Flags: review?(myk)
| Assignee | ||
Comment 2•14 years ago
|
||
I got a confirmation by mail from philipp that this patch make his addon work.
Updated•14 years ago
|
Priority: -- → P1
Target Milestone: --- → 1.1
Comment 3•14 years ago
|
||
Comment on attachment 540230 [details] [diff] [review]
Fix with tests
r=myk with the actual platform bug number inserted into the patch in the appropriate place.
Attachment #540230 -
Flags: review?(myk) → review+
| Assignee | ||
Comment 4•14 years ago
|
||
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•