Switch suite/mailnews to use Services.urlFormatter

RESOLVED FIXED in seamonkey2.4

Status

SeaMonkey
General
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: Ian Neal, Assigned: Ian Neal)

Tracking

Trunk
seamonkey2.4
Dependency tree / graph
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

7 years ago
Created attachment 540238 [details] [diff] [review]
suite switch to Services.urlFormatter

We import Services.jsm but we need to make better use of the urlFormatter provided by it.
This patch:
* Switches suite code to use urlFormatter provided by Services.jsm
* Does some code simplification around downloading dictionaries.
Attachment #540238 - Flags: review?(neil)

Comment 1

7 years ago
Comment on attachment 540238 [details] [diff] [review]
suite switch to Services.urlFormatter

Nice, but could you move the try/catch into goDictionaryDownload too?
(Assignee)

Comment 2

7 years ago
Created attachment 540315 [details] [diff] [review]
suite switch to Services.urlFormatter with try catch

Changes since last version:
* Moved try/catch to goDictionaryDownload helper
* Removed now unneeded addDictionary function and just call goDictionaryDownload directly from context menu.
Attachment #540238 - Attachment is obsolete: true
Attachment #540238 - Flags: review?(neil)
Attachment #540315 - Flags: review?(neil)

Comment 3

7 years ago
Comment on attachment 540315 [details] [diff] [review]
suite switch to Services.urlFormatter with try catch

>diff --git a/editor/ui/dialogs/content/EdSpellCheck.js b/editor/ui/dialogs/content/EdSpellCheck.js
I just thought... Does Thunderbird use this dialog?

>diff --git a/suite/mailnews/compose/prefs/pref-composing_messages.js b/suite/mailnews/compose/prefs/pref-composing_messages.js
> function SelectLanguage(aTarget) {
>   try {
Nit: overlooked this try/catch.
(Assignee)

Comment 4

7 years ago
Created attachment 540365 [details] [diff] [review]
suite switch to Services.urlFormatter with try catch and new name for helper [Checked in: Comment 8]

Changes since last version:
* Renamed helper to openDictionaryList to match TB so EdSpellCheck.js will work for them.
* Removed missed try/catch.
Attachment #540315 - Attachment is obsolete: true
Attachment #540315 - Flags: review?(neil)
Attachment #540365 - Flags: review?(neil)

Updated

7 years ago
Depends on: 620781

Comment 5

7 years ago
Comment on attachment 540365 [details] [diff] [review]
suite switch to Services.urlFormatter with try catch and new name for helper [Checked in: Comment 8]

Nice of Thunderbird to make things easy for you :-)
Attachment #540365 - Flags: review?(neil) → review+
(Assignee)

Comment 6

7 years ago
Comment on attachment 540365 [details] [diff] [review]
suite switch to Services.urlFormatter with try catch and new name for helper [Checked in: Comment 8]

To review impact of EdSpellCheck.js change.
Attachment #540365 - Flags: review?(mbanner)
(Assignee)

Comment 7

7 years ago
Comment on attachment 540365 [details] [diff] [review]
suite switch to Services.urlFormatter with try catch and new name for helper [Checked in: Comment 8]

Whoever can review the EdSpellCheck.js changes first.
Attachment #540365 - Flags: review?(dbienvenu)
Attachment #540365 - Flags: review?(mbanner)
Attachment #540365 - Flags: review?(dbienvenu)
Attachment #540365 - Flags: review+
(Assignee)

Comment 8

7 years ago
Comment on attachment 540365 [details] [diff] [review]
suite switch to Services.urlFormatter with try catch and new name for helper [Checked in: Comment 8]

http://hg.mozilla.org/comm-central/rev/0a3c60c01adf
Attachment #540365 - Attachment description: suite switch to Services.urlFormatter with try catch and new name for helper → suite switch to Services.urlFormatter with try catch and new name for helper [Checked in: Comment 8]
(Assignee)

Updated

7 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.4
You need to log in before you can comment on or make changes to this bug.