665294 - Switch suite to use Services.dirsvc

Status: RESOLVED FIXED

(SeaMonkey :: General, defect)

Description

[Ian Neal]

Attachment: helpers and switch to Services.dirsvc

At the moment we have Services.jsm imported but we're not making full use of it.
This patch:
* Creates helper for getting "Desktop" folder from Services.dirsvc
* Creates helper for getting nsIFile folders from Services.dirsvc
* Switches, where possible, to using either one of the new helpers or Services.dirsvc directly.

Comment 1

[[e-mail]]

Comment on attachment 540241 [details] [diff] [review]
helpers and switch to Services.dirsvc

>+function GetnsIFileFolder(aName)
I really don't like this function name. We could rename it GetSpecialDirectory, after the C++ convenience method NS_GetSpecialDirectory. Alternatively, most of the callers want the Profile folder, so you could implement GetProfileFolder for them, and use Services.dirsvc directly for the remaining ones.

Comment 2

[Ian Neal]

Attachment: helpers and switch to Services.dirsvc with less try catch

Changes since last version:
* Moved try/catch to goDictionaryDownload helper
* Removed now unneeded addDictionary function and just call goDictionaryDownload directly from context menu.

Comment 3

[Ian Neal]

Attachment: extra helpers and switch to Services.dirsvc

Changes since last correct patch:
* Renamed original new helper to GetSpecialDirectory.
* Added new helper GetUrlbarHistoryFile and used it for the four locations that need that file.

Comment 4

[[e-mail]]

Comment on attachment 540316 [details] [diff] [review]
extra helpers and switch to Services.dirsvc

>+  return GetSpecialDirectory("ProfD").append("urlbarhistory.sqlite");
...
>+  return GetSpecialDirectory("Home").append("journal.js");
This doesn't actually work; append alters the file object rather than returning (a new) one.

Comment 5

[Ian Neal]

Attachment: extra helpers and switch to Services.dirsvc with tweaked append [Checked in: Comment 7]

Changes since last version:
* Do append the old way.

Comment 6

[[e-mail]]

Comment on attachment 540358 [details] [diff] [review]
extra helpers and switch to Services.dirsvc with tweaked append [Checked in: Comment 7]

>+  var processDir = GetSpecialDirectory("ProfD");
You copied the variable name from editor, but it was getting a different special directory, which may well be the process dir (I can't remember them all offhand and I'm too tired to look it up). But technically this is the profile dir, not the process dir.

Comment 7

[Ian Neal]

Comment on attachment 540358 [details] [diff] [review]
extra helpers and switch to Services.dirsvc with tweaked append [Checked in: Comment 7]

Checked in with variable name changed to profileDir
http://hg.mozilla.org/comm-central/rev/e5d292f48f15