66533 - Add profile switching dialogs/code to winEmbed

Status: VERIFIED FIXED

(Core Graveyard :: Embedding: APIs, defect)

Description

[Adam Lock]

Add some dialogs to the winEmbed app that demonstrate how to select/switch 
profiles from an embedding app but also for smoketesting purposes. Add 
command-line options so the initial profile can be specified.

Comment 1

[Adam Lock]

Attachment: New profile chooser dialog and associated code

Comment 2

[Adam Lock]

This is work in progress profile switching code for winEmbed. The code works as 
it stands in this patch but I should polish it up a little bit before review.

Note you must manually build mozilla/profile to get the profile service because 
embed.mak doesn't build it at the moment.

Comments please.

Comment 3

[Conrad Carlen (not reading bugmail)]

I've also got profile management code for mfcEmbed. Adam, I'll send that for
reference.

Comment 4

[Adam Lock]

Attachment: Changes to enable profile switching at startup

Comment 5

[Adam Lock]

Hi Conrad,

Can you review these diffs please? They enable profile switching when winEmbed 
starts up.

The behaviour is this:

If there are no profiles, a "winEmbed" profile is created and used
If there is one profile, it is selected and used
If there are multiple profiles a dialog appears to allow the user to choose a 
profile.

I also fixed a problem with the WM_COMMAND handling code for the profile chooser 
dialog which meant it didn't work from "File|Choose Profile..." previously

Comment 6

[Conrad Carlen (not reading bugmail)]

Thanks, I'll take a look soon.

Comment 7

[Conrad Carlen (not reading bugmail)]

The piece that's missing from this is an application-level profile change
observer. This observer needs to do some things, whithout which profile
switching won't work. Check out what mfcEmbed does with that.

Comment 8

[Adam Lock]

Attachment: Patch containing the observer callbacks

Comment 9

[Adam Lock]

Conrad, the latest patch adds observer notifications to monitor for profile 
changes. The behaviour is to close all the windows on a profile change and open 
a new one with the initial URL in it.

Comment 10

[Adam Lock]

Attachment: profile switching moved to safe place in dialog proc

Comment 11

[Adam Lock]

Marking for 0.9. As winEmbed is no longer the default smoketester I may checkin 
what I've done on this so far to enable profiles to be activated even if 
switching from another doesn't work. This should enable me to clear bug 63999.

However I'll leave the bug open until profile switching is done in a 
satisfactory manner.

Comment 12

[Adam Lock]

winEmbed just received an update with new profile switching code. It isn't as 
sophisticated as mfcEmbed but seems to work reasonably well.

A couple of notes:

1. At startup don't double-click on a profile from the dialog. Click on it and 
hit the "Select" button, otherwise it thinks you hit cancel and quits. One 
line fix is pending.

2. Sometimes dynamically switching profiles causes a crash on exit. It looks as 
though one of the chrome objects is still registered with the observer service 
even though it's been destroyed. I thought weak pointers meant that couldn't 
happen so I'm investigating that one too.

Comment 13

[Adam Lock]

Profile double click issue has been fixed

Comment 14

[Judson Valeski]

closing as fixed. please open new bugs on the seperate issues.

Comment 15

[Michael Dunn]

Correction: Changing QA contact for the Embed API bugs to David Epstein.

Comment 16

[David Epstein]

Profile dlg in winEmbed. Profile switching works fine. 
profileService->SetCurrentProfile(newProfileName) used to switch profiles.