Remove unused variable maiAtkHyperlink from nsMaiHyperlink.cpp getUriCB()

VERIFIED FIXED in mozilla7

Status

()

Core
Disability Access APIs
VERIFIED FIXED
6 years ago
6 years ago

People

(Reporter: emorley, Assigned: emorley)

Tracking

(Blocks: 1 bug)

Trunk
mozilla7
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [build_warning])

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
accessible/src/atk/nsMaiHyperlink.cpp:218:22: warning: unused variable 'maiAtkHyperlink'

http://mxr.mozilla.org/mozilla-central/source/accessible/src/atk/nsMaiHyperlink.cpp#218

No longer used since bug 424264:
http://hg.mozilla.org/mozilla-central/diff/cb073c147f53/accessible/src/atk/nsMaiHyperlink.cpp
(Assignee)

Comment 1

6 years ago
Created attachment 540357 [details] [diff] [review]
Remove unused variable
Attachment #540357 - Flags: review?(surkov.alexander)

Updated

6 years ago
Attachment #540357 - Flags: review?(surkov.alexander) → review+
(Assignee)

Comment 2

6 years ago
http://dev.philringnalda.com/tbpl/?tree=Try&rev=0f7f8aa6e296
Keywords: checkin-needed
http://hg.mozilla.org/mozilla-central/rev/02e71c0a1bc0
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla7
(Assignee)

Updated

6 years ago
Duplicate of this bug: 458711
Mozilla/5.0 (Windows NT 5.1; rv:7.0) Gecko/20100101 Firefox/7.0

I visually inspected the code changes and maiAtkHyperlink variable is removed from nsMaiHyperlink.cpp:
http://hg.mozilla.org/mozilla-central/file/922f27baed98/accessible/src/atk/nsMaiHyperlink.cpp

Is there a test case to verify this manually or is it enough to mark this as Verified Fixed?

Thanks!

Comment 6

6 years ago
(In reply to Simona B [QA] from comment #5)
> Mozilla/5.0 (Windows NT 5.1; rv:7.0) Gecko/20100101 Firefox/7.0
> 
> I visually inspected the code changes and maiAtkHyperlink variable is
> removed from nsMaiHyperlink.cpp:
> http://hg.mozilla.org/mozilla-central/file/922f27baed98/accessible/src/atk/
> nsMaiHyperlink.cpp
> 
> Is there a test case to verify this manually or is it enough to mark this as
> Verified Fixed?

There's no test case. Visual confirmation is a way to go. So feel free mark verified.
Based on Comment 6 marking this as VERIFIED FIXED.

Thanks alexander!
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.