Closed
Bug 665391
Opened 14 years ago
Closed 14 years ago
Remove unused variable maiAtkHyperlink from nsMaiHyperlink.cpp getUriCB()
Categories
(Core :: Disability Access APIs, defect)
Core
Disability Access APIs
Tracking
()
VERIFIED
FIXED
mozilla7
People
(Reporter: emorley, Assigned: emorley)
References
(Blocks 1 open bug)
Details
(Whiteboard: [build_warning])
Attachments
(1 file)
889 bytes,
patch
|
surkov
:
review+
|
Details | Diff | Splinter Review |
accessible/src/atk/nsMaiHyperlink.cpp:218:22: warning: unused variable 'maiAtkHyperlink'
http://mxr.mozilla.org/mozilla-central/source/accessible/src/atk/nsMaiHyperlink.cpp#218
No longer used since bug 424264:
http://hg.mozilla.org/mozilla-central/diff/cb073c147f53/accessible/src/atk/nsMaiHyperlink.cpp
Assignee | ||
Comment 1•14 years ago
|
||
Attachment #540357 -
Flags: review?(surkov.alexander)
Updated•14 years ago
|
Attachment #540357 -
Flags: review?(surkov.alexander) → review+
Assignee | ||
Comment 2•14 years ago
|
||
Keywords: checkin-needed
Comment 3•14 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla7
Comment 5•13 years ago
|
||
Mozilla/5.0 (Windows NT 5.1; rv:7.0) Gecko/20100101 Firefox/7.0
I visually inspected the code changes and maiAtkHyperlink variable is removed from nsMaiHyperlink.cpp:
http://hg.mozilla.org/mozilla-central/file/922f27baed98/accessible/src/atk/nsMaiHyperlink.cpp
Is there a test case to verify this manually or is it enough to mark this as Verified Fixed?
Thanks!
Comment 6•13 years ago
|
||
(In reply to Simona B [QA] from comment #5)
> Mozilla/5.0 (Windows NT 5.1; rv:7.0) Gecko/20100101 Firefox/7.0
>
> I visually inspected the code changes and maiAtkHyperlink variable is
> removed from nsMaiHyperlink.cpp:
> http://hg.mozilla.org/mozilla-central/file/922f27baed98/accessible/src/atk/
> nsMaiHyperlink.cpp
>
> Is there a test case to verify this manually or is it enough to mark this as
> Verified Fixed?
There's no test case. Visual confirmation is a way to go. So feel free mark verified.
Comment 7•13 years ago
|
||
Based on Comment 6 marking this as VERIFIED FIXED.
Thanks alexander!
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•