665391 - Remove unused variable maiAtkHyperlink from nsMaiHyperlink.cpp getUriCB()

Status: VERIFIED FIXED

(Core :: Disability Access APIs, defect)

Description

[Ed Morley [:emorley]]

accessible/src/atk/nsMaiHyperlink.cpp:218:22: warning: unused variable 'maiAtkHyperlink'

http://mxr.mozilla.org/mozilla-central/source/accessible/src/atk/nsMaiHyperlink.cpp#218

No longer used since bug 424264:
http://hg.mozilla.org/mozilla-central/diff/cb073c147f53/accessible/src/atk/nsMaiHyperlink.cpp

Comment 1

[Ed Morley [:emorley]]

Attachment: Remove unused variable

Comment 2

[Ed Morley [:emorley]]

http://dev.philringnalda.com/tbpl/?tree=Try&rev=0f7f8aa6e296

Comment 3

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

http://hg.mozilla.org/mozilla-central/rev/02e71c0a1bc0

Comment 5

[Simona Badau, Desktop QA]

Mozilla/5.0 (Windows NT 5.1; rv:7.0) Gecko/20100101 Firefox/7.0

I visually inspected the code changes and maiAtkHyperlink variable is removed from nsMaiHyperlink.cpp:
http://hg.mozilla.org/mozilla-central/file/922f27baed98/accessible/src/atk/nsMaiHyperlink.cpp

Is there a test case to verify this manually or is it enough to mark this as Verified Fixed?

Thanks!

Comment 6

[alexander :surkov (:asurkov)]

(In reply to Simona B [QA] from comment #5)
> Mozilla/5.0 (Windows NT 5.1; rv:7.0) Gecko/20100101 Firefox/7.0
> 
> I visually inspected the code changes and maiAtkHyperlink variable is
> removed from nsMaiHyperlink.cpp:
> http://hg.mozilla.org/mozilla-central/file/922f27baed98/accessible/src/atk/
> nsMaiHyperlink.cpp
> 
> Is there a test case to verify this manually or is it enough to mark this as
> Verified Fixed?

There's no test case. Visual confirmation is a way to go. So feel free mark verified.

Comment 7

[Simona Badau, Desktop QA]

Based on Comment 6 marking this as VERIFIED FIXED.

Thanks alexander!