66543 - use of MOZ_MAIL_NEWS in C++

Status: VERIFIED FIXED

(SeaMonkey :: UI Design, defect, P5)

Description

[Alec Flett]

I don't know why, but nsGtkMozRemoteHelper is using MOZ_MAIL_NEWS as an #ifdef.
MOZ_MAIL_NEWS is not supposed to be defined in C++, and it was agreed a while
back that a build with and without MOZ_MAIL_NEWS defined should produce the same
navigator binaries.. so basically we should not have this!

it looks like it's only using it for the mailto remote command, but it seems
like we should replace this with an attempt to open a mailto: url through the
uriloader - that way if we had a mailto handler such as Mozilla Mail, then it
would load it. Otherwise, it would give an error.

CC'ing cls to see why MOZ_MAIL_NEWS is defined in C++

Comment 1

[Christopher Blizzard (:blizzard)]

Actually, now that you mention it there are a lot of things in that file that
should be using the URI loader that aren't.  I wrote that before I knew about
the URI loader and thought that I had to do all the loading by hand.

Comment 2

[cls]

Sorry about the spam. An unset priority should be less than P5.  

Comment 3

[cls]

*** Bug 92394 has been marked as a duplicate of this bug. ***

Comment 4

[Christopher Blizzard (:blizzard)]

-> [e-mail]

Comment 5

[Christopher Blizzard (:blizzard)]

Fixed.

Comment 6

[cls]

Attachment: Remove -DMOZ_MAIL_NEWS from build

Comment 7

[Stuart Parmenter]

r=pavlov

Comment 8

[Alec Flett]

Comment on attachment 48682 [details] [diff] [review]
Remove -DMOZ_MAIL_NEWS from build

awesome! sr=alecf

Comment 9

[sairuh (rarely reading bugmail)]

rs-vrfy.