netwerk/wifi/nsWifiScannerMac.cpp:119: warning: unused variable 'rv'
netwerk/wifi/nsWifiScannerMac.cpp:255: warning: unused variable 'rv'
netwerk/wifi/nsWifiScannerUnix.cpp:213:20: warning: unused variable 'rv'
213 nsresult rv = proxy->OnChange(result, resultCount);
214 LOG( ("... sent %d\n", rv));
Created attachment 540451 [details] [diff] [review]
Fix build warnings
Chris, any idea if this pattern occurs enough to warrant creating some kind of LoggingOnly template?
Comment on attachment 540451 [details] [diff] [review]
Fix build warnings
Maybe we should just drop the LOG() all together.
(In reply to comment #2)
> Chris, any idea if this pattern occurs enough to warrant creating some kind
> of LoggingOnly template?
I don't know; personally, I don't run across it. It's not something we would add to mfbt unless mfbt grew logging facilities, but something like a LoggingOnly helper doesn't need to live in mfbt.
Although let me know if you'd rather me just get rid of the LOG()s.
ed, get rid of the logs. rs+
Just the LOG("... sent %d\n", rv) variants or do you mean some/all of the others whilst I'm there? (I'm presuming the former).
All LOG()s in /netwerk/wifi/
Doug, any thoughts about comment 7? :-)
Doug, please may I have an answer to comment 7 - I'm fairly keen to get this fairly trivial bug off my open assigned list. Thanks :-)
Doug, it's been 6 weeks, could I have a response to comment 7 please.
sorry. my bad.
just the |LOG("... sent %d\n", rv)| ones. The others are important when debugging.
Great, thanks Doug :-)
Created attachment 552951 [details] [diff] [review]
Bug 667535 refactored the existing code, so now less instances to change.
Carrying forwards rs+ from comment 6.
Created attachment 552952 [details] [diff] [review]
TortoiseHg being useless again (UI randomly resetting MQ included files so nothing gets qrefreshed).