665532 - Fix unused variable warnings in nsWifiMonitor.cpp

Status: RESOLVED FIXED

(Core :: Networking, defect)

Description

[Ed Morley [:emorley]]

netwerk/wifi/nsWifiScannerMac.cpp:119: warning: unused variable 'rv'
netwerk/wifi/nsWifiScannerMac.cpp:255: warning: unused variable 'rv'
netwerk/wifi/nsWifiScannerUnix.cpp:213:20: warning: unused variable 'rv'

eg:

213           nsresult rv = proxy->OnChange(result, resultCount);
214           LOG( ("... sent %d\n", rv));

http://mxr.mozilla.org/mozilla-central/source/netwerk/wifi/nsWifiScannerUnix.cpp#213
http://mxr.mozilla.org/mozilla-central/source/netwerk/wifi/nsWifiScannerWin.cpp#194
http://mxr.mozilla.org/mozilla-central/source/netwerk/wifi/nsWifiScannerMac.cpp#119
http://mxr.mozilla.org/mozilla-central/source/netwerk/wifi/nsWifiScannerMac.cpp#256
http://mxr.mozilla.org/mozilla-central/source/netwerk/wifi/nsWifiScannerSolaris.cpp#217

Comment 1

[Ed Morley [:emorley]]

Attachment: Fix build warnings

Comment 2

[Josh Matthews [:jdm]]

Chris, any idea if this pattern occurs enough to warrant creating some kind of LoggingOnly template?

Comment 3

[Doug Turner (:dougt)]

Comment on attachment 540451 [details] [diff] [review]
Fix build warnings

Maybe we should just drop the LOG() all together.

Comment 4

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

(In reply to comment #2)
> Chris, any idea if this pattern occurs enough to warrant creating some kind
> of LoggingOnly template?

I don't know; personally, I don't run across it.  It's not something we would add to mfbt unless mfbt grew logging facilities, but something like a LoggingOnly helper doesn't need to live in mfbt.

Comment 5

[Ed Morley [:emorley]]

http://dev.philringnalda.com/tbpl/?tree=Try&rev=fd911766b068

Although let me know if you'd rather me just get rid of the LOG()s.

Comment 6

[Doug Turner (:dougt)]

ed, get rid of the logs.  rs+

Comment 7

[Ed Morley [:emorley]]

Just the LOG("... sent %d\n", rv) variants or do you mean some/all of the others whilst I'm there? (I'm presuming the former).

All LOG()s in /netwerk/wifi/
http://mxr.mozilla.org/mozilla-central/search?string=LOG%28&case=1&find=%2Fnetwerk%2Fwifi%2F&findi=&filter=^[^\0]*%24&hitlimit=&tree=mozilla-central

Comment 8

[Ed Morley [:emorley]]

Doug, any thoughts about comment 7? :-)

Comment 9

[Ed Morley [:emorley]]

Doug?

:-)

Comment 10

[Ed Morley [:emorley]]

Doug, please may I have an answer to comment 7 - I'm fairly keen to get this fairly trivial bug off my open assigned list. Thanks :-)

Comment 11

[Ed Morley [:emorley]]

Doug, it's been 6 weeks, could I have a response to comment 7 please.

Comment 12

[Doug Turner (:dougt)]

sorry.  my bad.

just the |LOG("... sent %d\n", rv)| ones.  The others are important when debugging.

Comment 13

[Ed Morley [:emorley]]

Great, thanks Doug :-)

Comment 14

[Ed Morley [:emorley]]

Attachment: Patch v2

Bug 667535 refactored the existing code, so now less instances to change.
Carrying forwards rs+ from comment 6.

Comment 15

[Ed Morley [:emorley]]

Attachment: Patch v2a

TortoiseHg being useless again (UI randomly resetting MQ included files so nothing gets qrefreshed).

Comment 16

[Daniel Holbert [:dholbert]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/ec9e06287fc7

Comment 17

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

http://hg.mozilla.org/mozilla-central/rev/96fa4289361e

Comment 18

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

http://hg.mozilla.org/mozilla-central/rev/ec9e06287fc7