Last Comment Bug 665532 - Fix unused variable warnings in nsWifiMonitor.cpp
: Fix unused variable warnings in nsWifiMonitor.cpp
Status: RESOLVED FIXED
[build_warning]
:
Product: Core
Classification: Components
Component: Networking (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla8
Assigned To: Ed Morley [:emorley]
:
Mentors:
Depends on:
Blocks: buildwarning
  Show dependency treegraph
 
Reported: 2011-06-20 06:52 PDT by Ed Morley [:emorley]
Modified: 2011-08-15 02:39 PDT (History)
6 users (show)
emorley: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Fix build warnings (4.32 KB, patch)
2011-06-20 07:00 PDT, Ed Morley [:emorley]
doug.turner: review-
Details | Diff | Splinter Review
Patch v2 (214 bytes, patch)
2011-08-14 03:44 PDT, Ed Morley [:emorley]
no flags Details | Diff | Splinter Review
Patch v2a (1.67 KB, patch)
2011-08-14 03:49 PDT, Ed Morley [:emorley]
no flags Details | Diff | Splinter Review

Description Ed Morley [:emorley] 2011-06-20 06:52:20 PDT
netwerk/wifi/nsWifiScannerMac.cpp:119: warning: unused variable 'rv'
netwerk/wifi/nsWifiScannerMac.cpp:255: warning: unused variable 'rv'
netwerk/wifi/nsWifiScannerUnix.cpp:213:20: warning: unused variable 'rv'

eg:

213           nsresult rv = proxy->OnChange(result, resultCount);
214           LOG( ("... sent %d\n", rv));

http://mxr.mozilla.org/mozilla-central/source/netwerk/wifi/nsWifiScannerUnix.cpp#213
http://mxr.mozilla.org/mozilla-central/source/netwerk/wifi/nsWifiScannerWin.cpp#194
http://mxr.mozilla.org/mozilla-central/source/netwerk/wifi/nsWifiScannerMac.cpp#119
http://mxr.mozilla.org/mozilla-central/source/netwerk/wifi/nsWifiScannerMac.cpp#256
http://mxr.mozilla.org/mozilla-central/source/netwerk/wifi/nsWifiScannerSolaris.cpp#217
Comment 1 Ed Morley [:emorley] 2011-06-20 07:00:59 PDT
Created attachment 540451 [details] [diff] [review]
Fix build warnings
Comment 2 Josh Matthews [:jdm] (away until 9/3) 2011-06-20 07:17:26 PDT
Chris, any idea if this pattern occurs enough to warrant creating some kind of LoggingOnly template?
Comment 3 Doug Turner (:dougt) 2011-06-20 09:39:02 PDT
Comment on attachment 540451 [details] [diff] [review]
Fix build warnings

Maybe we should just drop the LOG() all together.
Comment 4 Chris Jones [:cjones] inactive; ni?/f?/r? if you need me 2011-06-20 11:49:00 PDT
(In reply to comment #2)
> Chris, any idea if this pattern occurs enough to warrant creating some kind
> of LoggingOnly template?

I don't know; personally, I don't run across it.  It's not something we would add to mfbt unless mfbt grew logging facilities, but something like a LoggingOnly helper doesn't need to live in mfbt.
Comment 5 Ed Morley [:emorley] 2011-06-21 04:45:30 PDT
http://dev.philringnalda.com/tbpl/?tree=Try&rev=fd911766b068

Although let me know if you'd rather me just get rid of the LOG()s.
Comment 6 Doug Turner (:dougt) 2011-06-23 07:52:26 PDT
ed, get rid of the logs.  rs+
Comment 7 Ed Morley [:emorley] 2011-06-25 06:27:28 PDT
Just the LOG("... sent %d\n", rv) variants or do you mean some/all of the others whilst I'm there? (I'm presuming the former).

All LOG()s in /netwerk/wifi/
http://mxr.mozilla.org/mozilla-central/search?string=LOG%28&case=1&find=%2Fnetwerk%2Fwifi%2F&findi=&filter=^[^\0]*%24&hitlimit=&tree=mozilla-central
Comment 8 Ed Morley [:emorley] 2011-07-02 10:27:49 PDT
Doug, any thoughts about comment 7? :-)
Comment 9 Ed Morley [:emorley] 2011-07-16 02:42:05 PDT
Doug?

:-)
Comment 10 Ed Morley [:emorley] 2011-07-25 05:53:09 PDT
Doug, please may I have an answer to comment 7 - I'm fairly keen to get this fairly trivial bug off my open assigned list. Thanks :-)
Comment 11 Ed Morley [:emorley] 2011-08-06 17:47:57 PDT
Doug, it's been 6 weeks, could I have a response to comment 7 please.
Comment 12 Doug Turner (:dougt) 2011-08-08 08:38:08 PDT
sorry.  my bad.

just the |LOG("... sent %d\n", rv)| ones.  The others are important when debugging.
Comment 13 Ed Morley [:emorley] 2011-08-14 03:39:33 PDT
Great, thanks Doug :-)
Comment 14 Ed Morley [:emorley] 2011-08-14 03:44:05 PDT
Created attachment 552951 [details] [diff] [review]
Patch v2

Bug 667535 refactored the existing code, so now less instances to change.
Carrying forwards rs+ from comment 6.
Comment 15 Ed Morley [:emorley] 2011-08-14 03:49:12 PDT
Created attachment 552952 [details] [diff] [review]
Patch v2a

TortoiseHg being useless again (UI randomly resetting MQ included files so nothing gets qrefreshed).
Comment 16 Daniel Holbert [:dholbert] 2011-08-14 10:43:38 PDT
http://hg.mozilla.org/integration/mozilla-inbound/rev/ec9e06287fc7
Comment 17 :Ms2ger (⌚ UTC+1/+2) 2011-08-14 10:45:31 PDT
http://hg.mozilla.org/mozilla-central/rev/96fa4289361e
Comment 18 :Ms2ger (⌚ UTC+1/+2) 2011-08-15 02:39:19 PDT
http://hg.mozilla.org/mozilla-central/rev/ec9e06287fc7

Note You need to log in before you can comment on or make changes to this bug.