Closed Bug 665534 Opened 8 years ago Closed 8 years ago

Fix unused variable warnings in nsEmbedFunctions.cpp

Categories

(Toolkit :: Startup and Profile System, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla8

People

(Reporter: emorley, Assigned: emorley)

References

(Blocks 1 open bug)

Details

(Whiteboard: [build_warning])

Attachments

(1 file, 1 obsolete file)

toolkit/xre/nsEmbedFunctions.cpp:420:8: warning: unused variable 'ok'
toolkit/xre/nsEmbedFunctions.cpp:686:16: warning: unused variable 'ioLoop'

http://mxr.mozilla.org/mozilla-central/source/toolkit/xre/nsEmbedFunctions.cpp#420

http://mxr.mozilla.org/mozilla-central/source/toolkit/xre/nsEmbedFunctions.cpp#686
Attached patch Fix build warnings (obsolete) — Splinter Review
Attachment #540454 - Flags: review?(benjamin)
Updated patch that uses DebugOnly instead of #ifdef DEBUG.
Attachment #540454 - Attachment is obsolete: true
Attachment #540454 - Flags: review?(benjamin)
Attachment #540486 - Flags: review?(benjamin)
Comment on attachment 540486 [details] [diff] [review]
Fix build warnings v2

Adding alternative reviewer, since bsmedberg is busy. Thanks :-)
Attachment #540486 - Flags: review?(robert.bugzilla)
Comment on attachment 540486 [details] [diff] [review]
Fix build warnings v2

tossing this review over to mossop since it will likely be awhile until I can get to it
Attachment #540486 - Flags: review?(robert.bugzilla) → review?(dtownsend)
Attachment #540486 - Flags: review?(dtownsend)
Attachment #540486 - Flags: review?(benjamin)
Attachment #540486 - Flags: review+
Keywords: checkin-needed
http://hg.mozilla.org/integration/mozilla-inbound/rev/fceffb1b020b
Flags: in-testsuite-
Keywords: checkin-needed
Target Milestone: --- → mozilla8
http://hg.mozilla.org/mozilla-central/rev/fceffb1b020b
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.