Last Comment Bug 665546 - Fix unused variable warning in nsMediaStream.cpp
: Fix unused variable warning in nsMediaStream.cpp
Status: RESOLVED FIXED
[build_warning]
:
Product: Core
Classification: Components
Component: Audio/Video (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla7
Assigned To: Ed Morley [:emorley]
:
Mentors:
Depends on:
Blocks: buildwarning
  Show dependency treegraph
 
Reported: 2011-06-20 08:00 PDT by Ed Morley [:emorley]
Modified: 2011-06-21 12:14 PDT (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Fix build warning (1.01 KB, patch)
2011-06-20 08:03 PDT, Ed Morley [:emorley]
josh: review-
Details | Diff | Splinter Review
Fix build warning v2 (1.51 KB, patch)
2011-06-20 08:46 PDT, Ed Morley [:emorley]
roc: review+
Details | Diff | Splinter Review

Description Ed Morley [:emorley] 2011-06-20 08:00:21 PDT
content/media/nsMediaStream.cpp:334:16: warning: unused variable 'rv'

http://mxr.mozilla.org/mozilla-central/source/content/media/nsMediaStream.cpp#334
Comment 1 Ed Morley [:emorley] 2011-06-20 08:03:27 PDT
Created attachment 540469 [details] [diff] [review]
Fix build warning
Comment 2 Josh Matthews [:jdm] 2011-06-20 08:21:26 PDT
Comment on attachment 540469 [details] [diff] [review]
Fix build warning

Please use DebugOnly instead. See http://mxr.mozilla.org/mozilla-central/source/netwerk/ipc/NeckoMessageUtils.h#110 for an example.
Comment 3 Ed Morley [:emorley] 2011-06-20 08:46:46 PDT
Created attachment 540480 [details] [diff] [review]
Fix build warning v2

Updated patch that uses DebugOnly instead of #ifdef DEBUG.
Comment 4 Robert O'Callahan (:roc) (email my personal email if necessary) 2011-06-20 15:40:37 PDT
Comment on attachment 540480 [details] [diff] [review]
Fix build warning v2

Review of attachment 540480 [details] [diff] [review]:
-----------------------------------------------------------------
Comment 5 Ed Morley [:emorley] 2011-06-21 04:54:45 PDT
http://dev.philringnalda.com/tbpl/?tree=Try&rev=fd911766b068
Comment 6 :Ms2ger (⌚ UTC+1/+2) 2011-06-21 12:14:51 PDT
http://hg.mozilla.org/mozilla-central/rev/1ea90ba9d998

Note You need to log in before you can comment on or make changes to this bug.