665565 - Make fuller use of GetStringPref in suite

Status: RESOLVED FIXED

(SeaMonkey :: General, defect)

Description

[Ian Neal]

Attachment: switch more of suite to use GetStringPref

There are various parts of the suite code that could use GetStringPref helper from utilityOverlay.js
This patch:
* Tweaks GetStringPref helper to take a second argument for optional use.
* Switches more of the suite code to use GetStringPref helper.

Comment 1

[Ian Neal]

Attachment: switch more of suite to use GetStringPref v2

Changes since last version:
* Fixed an issue where a try/catch had been hiding a missing Services.

Comment 2

[[e-mail]]

Comment on attachment 540607 [details] [diff] [review]
switch more of suite to use GetStringPref v2

>+  url = GetStringPref("sidebar.customize.all_panels.url", "about:blank");
If this is the only user, this could be written
url = GetStringPref("sidebar.customize.all_panels.url") || "about:blank";

>         if (LDAPSession) {
>-            let url = sPrefs.getComplexValue(autocompleteDirectory +".uri",
>-              Components.interfaces.nsISupportsString).data;
>+            let url = GetStringPref(autocompleteDirectory +".uri");
I don't really want to fiddle with this code: it's slated to be ripped out and replaced with a toolkit-based autocomplete component, see bug 452232. r- because of that.

Comment 3

[Ian Neal]

Attachment: switch more of suite to use GetStringPref without LDAP [Checked in: Comment 6]

Changes since previous version:
* No tweaking of GetStringPref now.
* Removed LDAP changes.
* Made suggested changes to sidebar and inlined variable declaration.

Comment 4

[[e-mail]]

Comment on attachment 541921 [details] [diff] [review]
switch more of suite to use GetStringPref without LDAP [Checked in: Comment 6]

>-    url = urlFormatter.formatURL(url);
[Oops, looks like urlFormatter was never declared?]

Comment 5

[Ian Neal]

Comment on attachment 541921 [details] [diff] [review]
switch more of suite to use GetStringPref without LDAP [Checked in: Comment 6]

http://hg.mozilla.org/comm-central/rev/322b0049a5a7

Comment 6

[Ian Neal]

Comment on attachment 541921 [details] [diff] [review]
switch more of suite to use GetStringPref without LDAP [Checked in: Comment 6]

Backed out incorrect patch:
http://hg.mozilla.org/comm-central/rev/18cdf1e1fc2b
Correct patch checked in:
http://hg.mozilla.org/comm-central/rev/e7d8e36b4769