Kill AddEventListenerByIID/RemoveEventListenerByIID from content

VERIFIED FIXED in mozilla7

Status

()

Core
DOM
VERIFIED FIXED
6 years ago
6 years ago

People

(Reporter: sicking, Assigned: sicking)

Tracking

Trunk
mozilla7
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

Created attachment 540521 [details] [diff] [review]
Remove from nsXULPopupListener
Attachment #540521 - Flags: review?(Olli.Pettay)
Created attachment 540529 [details] [diff] [review]
Remove from nsTextEditorState
Assignee: nobody → jonas
Attachment #540529 - Flags: review?(jst)
Blocks: 661297

Updated

6 years ago
Attachment #540529 - Flags: review?(jst) → review+
Landed the texteditorstate patch:
http://hg.mozilla.org/mozilla-central/rev/ce10fd5d82c6

Updated

6 years ago
Attachment #540521 - Flags: review?(Olli.Pettay) → review+
Comment on attachment 540521 [details] [diff] [review]
Remove from nsXULPopupListener

>diff --git a/content/xul/content/src/nsXULPopupListener.cpp b/content/xul/content/src/nsXULPopupListener.cpp
>--- a/content/xul/content/src/nsXULPopupListener.cpp
>+++ b/content/xul/content/src/nsXULPopupListener.cpp
>+nsXULPopupListener::HandleEvent(nsIDOMEvent* aEvent)

>   nsCOMPtr<nsIDOMMouseEvent> mouseEvent;
>-  mouseEvent = do_QueryInterface(aMouseEvent);
>+  mouseEvent = do_QueryInterface(aEvent);

This can be on one line.

>@@ -479,12 +467,11 @@ nsXULPopupListener::LaunchPopup(nsIDOMEv
> nsresult
> NS_NewXULPopupListener(nsIDOMElement* aElement, PRBool aIsContext,
>                        nsIDOMEventListener** aListener)
> {
>     nsXULPopupListener* pl = new nsXULPopupListener(aElement, aIsContext);
>     if (!pl)
>       return NS_ERROR_OUT_OF_MEMORY;
> 
>-    *aListener = static_cast<nsIDOMMouseListener *>(pl);
>-    NS_ADDREF(*aListener);
>+    NS_ADDREF(*aListener = pl);

This can be NS_ADDREF(*aListener = new nsXULPopupListener(aElement, aIsContext));
Checked in the popuplistener patch, including a change to kill NS_NewXULPopupListener completely which got r=ms2ger over irc.

http://hg.mozilla.org/integration/mozilla-inbound/rev/d51b398dc5c7
Status: NEW → ASSIGNED
http://hg.mozilla.org/mozilla-central/rev/d51b398dc5c7

I assume the bug should stay open, otherwise please fix it accordingly.
Nope, it should be fixed now.
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla7
It seems that AddEventListenerByIID/RemoveEventListenerByIID was removed from the content.
Setting resolution to VERIFIED FIXED.
Thanks.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.