665609 - Kill AddEventListenerByIID/RemoveEventListenerByIID from content

Status: VERIFIED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Attachment: Remove from nsXULPopupListener

Comment 1

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Attachment: Remove from nsTextEditorState

Comment 2

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Landed the texteditorstate patch:
http://hg.mozilla.org/mozilla-central/rev/ce10fd5d82c6

Comment 3

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 540521 [details] [diff] [review]
Remove from nsXULPopupListener

>diff --git a/content/xul/content/src/nsXULPopupListener.cpp b/content/xul/content/src/nsXULPopupListener.cpp
>--- a/content/xul/content/src/nsXULPopupListener.cpp
>+++ b/content/xul/content/src/nsXULPopupListener.cpp
>+nsXULPopupListener::HandleEvent(nsIDOMEvent* aEvent)

>   nsCOMPtr<nsIDOMMouseEvent> mouseEvent;
>-  mouseEvent = do_QueryInterface(aMouseEvent);
>+  mouseEvent = do_QueryInterface(aEvent);

This can be on one line.

>@@ -479,12 +467,11 @@ nsXULPopupListener::LaunchPopup(nsIDOMEv
> nsresult
> NS_NewXULPopupListener(nsIDOMElement* aElement, PRBool aIsContext,
>                        nsIDOMEventListener** aListener)
> {
>     nsXULPopupListener* pl = new nsXULPopupListener(aElement, aIsContext);
>     if (!pl)
>       return NS_ERROR_OUT_OF_MEMORY;
> 
>-    *aListener = static_cast<nsIDOMMouseListener *>(pl);
>-    NS_ADDREF(*aListener);
>+    NS_ADDREF(*aListener = pl);

This can be NS_ADDREF(*aListener = new nsXULPopupListener(aElement, aIsContext));

Comment 4

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Checked in the popuplistener patch, including a change to kill NS_NewXULPopupListener completely which got r=ms2ger over irc.

http://hg.mozilla.org/integration/mozilla-inbound/rev/d51b398dc5c7

Comment 5

[Marco Bonardo [:mak]]

http://hg.mozilla.org/mozilla-central/rev/d51b398dc5c7

I assume the bug should stay open, otherwise please fix it accordingly.

Comment 6

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Nope, it should be fixed now.

Comment 7

[Trif Andrei-Alin[:AlinT]]

It seems that AddEventListenerByIID/RemoveEventListenerByIID was removed from the content.
Setting resolution to VERIFIED FIXED.
Thanks.