Fix unused variable warnings in GLContext.cpp & GLContextProviderEGL.cpp

VERIFIED FIXED in mozilla7

Status

()

Core
Graphics
VERIFIED FIXED
6 years ago
6 years ago

People

(Reporter: emorley, Assigned: emorley)

Tracking

(Blocks: 1 bug)

Trunk
mozilla7
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [build_warning][inbound])

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
gfx/thebes/GLContext.cpp:1780:16: warning: unused variable 'status'
http://mxr.mozilla.org/mozilla-central/source/gfx/thebes/GLContext.cpp#1780

gfx/thebes/GLContextProviderEGL.cpp:1770: warning: unused variable 'context'
http://mxr.mozilla.org/mozilla-central/source/gfx/thebes/GLContextProviderEGL.cpp#1770

gfx/thebes/GLContextProviderEGL.cpp:2168: warning: unused variable 'context'
http://mxr.mozilla.org/mozilla-central/source/gfx/thebes/GLContextProviderEGL.cpp#2168

gfx/thebes/GLContextProviderEGL.cpp:2169: warning: unused variable 'config'
http://mxr.mozilla.org/mozilla-central/source/gfx/thebes/GLContextProviderEGL.cpp#2169
(Assignee)

Comment 1

6 years ago
Created attachment 540534 [details] [diff] [review]
Fix build warnings

For the GLContext.cpp change, I'm wondering whether the whole |fCheckFramebufferStatus(LOCAL_GL_FRAMEBUFFER)| line can be put inside an #ifdef DEBUG block, since it would seem that the call isn't required at all, since it does nothing other than check the status. Or does it still need to be called?

If the call isn't needed, is there a DebugOnly macro for the whole line (as opposed to just the variable), or do I just fall back to #ifdef DEBUG?

Thanks :-)
Attachment #540534 - Flags: review?(joe)
(Assignee)

Comment 2

6 years ago
http://dev.philringnalda.com/tbpl/?tree=Try&rev=fd911766b068
Attachment #540534 - Flags: review?(joe) → review+
(Assignee)

Comment 3

6 years ago
Joe, thanks for the quick review :-) Just wanted to double check before I mark this checkin-needed, that comment 1 didn't apply? Thanks!
Better to keep it for now.
(Assignee)

Updated

6 years ago
Keywords: checkin-needed
http://hg.mozilla.org/integration/mozilla-inbound/rev/093d1650e7a7
Keywords: checkin-needed
Whiteboard: [build_warning] → [build_warning][inbound]
http://hg.mozilla.org/mozilla-central/rev/093d1650e7a7
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla7
Verified that the following files were updated in mozillla-central repository: 
gfx/thebes/GLContext.cpp
gfx/thebes/GLContextProviderEGL.cpp

Is this enough to verify the fix and mark the bug accordigly (VERIFIED-FIXED)?

Thank you!
Yup, I'd say so.  Setting to VERIFIED based on comment 7. Thanks!
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.