gfx/thebes/GLContext.cpp:1780:16: warning: unused variable 'status' http://mxr.mozilla.org/mozilla-central/source/gfx/thebes/GLContext.cpp#1780 gfx/thebes/GLContextProviderEGL.cpp:1770: warning: unused variable 'context' http://mxr.mozilla.org/mozilla-central/source/gfx/thebes/GLContextProviderEGL.cpp#1770 gfx/thebes/GLContextProviderEGL.cpp:2168: warning: unused variable 'context' http://mxr.mozilla.org/mozilla-central/source/gfx/thebes/GLContextProviderEGL.cpp#2168 gfx/thebes/GLContextProviderEGL.cpp:2169: warning: unused variable 'config' http://mxr.mozilla.org/mozilla-central/source/gfx/thebes/GLContextProviderEGL.cpp#2169
Created attachment 540534 [details] [diff] [review] Fix build warnings For the GLContext.cpp change, I'm wondering whether the whole |fCheckFramebufferStatus(LOCAL_GL_FRAMEBUFFER)| line can be put inside an #ifdef DEBUG block, since it would seem that the call isn't required at all, since it does nothing other than check the status. Or does it still need to be called? If the call isn't needed, is there a DebugOnly macro for the whole line (as opposed to just the variable), or do I just fall back to #ifdef DEBUG? Thanks :-)
Joe, thanks for the quick review :-) Just wanted to double check before I mark this checkin-needed, that comment 1 didn't apply? Thanks!
Better to keep it for now.
Verified that the following files were updated in mozillla-central repository: gfx/thebes/GLContext.cpp gfx/thebes/GLContextProviderEGL.cpp Is this enough to verify the fix and mark the bug accordigly (VERIFIED-FIXED)? Thank you!
Yup, I'd say so. Setting to VERIFIED based on comment 7. Thanks!