665697 - kuma: Allow contributors to edit sections instead of the entire article

Status: RESOLVED FIXED

(developer.mozilla.org Graveyard :: Wiki pages, defect, P2)

Comment 1

[Luke Crouch [:groovecoder]]

For each header, add an 'edit' link.

Clicking 'edit' takes the user to the edit page with the section content in the text area, along with the preceding and subsequent section content for context.

Edit sections are H1->H1, H2->H2, H3->H3

Comment 2

[Luke Crouch [:groovecoder]]

Sheppy and/or Janet,

What is the main goal of this feature? To minimize the text an editor has to view while editing? Or to enable multiple editors to change different sections of the same page without collisions?

Comment 3

[John Karahalis]

From what I understand, Janet's main goal is to be able to edit and update all site content without needing to file a Bugzilla ticket for each edit.

Janet, please correct me if I'm wrong.

Comment 4

[Luke Crouch [:groovecoder]]

John - wrong bug. ;) I think you're talking about bug 674736. This is a kuma wiki bug.

Comment 5

[John Karahalis [:openjck]]

I am confusing this with bug 674736, yes. I must have read your comment without double-checking the title.

Thanks for keeping me honest.

Comment 6

[Janet Swisher]

(In reply to comment #2)
> What is the main goal of this feature? To minimize the text an editor has to
> view while editing? Or to enable multiple editors to change different
> sections of the same page without collisions?

I would say that minimizing what's being edited is the main goal, and simultaneous edits is a side-benefit. When I've used this feature on wikis that support it (MediaWiki, Confluence), it's often when I want to make a small change to the middle of a long article. If you get the whole article in the editor, you have to re-find the spot that you wanted to edit (scrolling down, etc.), which is an interruption to the mental work flow.

Comment 7

[Luke Crouch [:groovecoder]]

That's good from a technical standpoint too. Letting one editor change a single article section at a time is easier than marshaling multiple edits to article sections at a time.

If we want that feature later, we should file another bug.

Comment 8

[Luke Crouch [:groovecoder]]

implemented rough draft of the feature. emailed sheppy and janet to get feedback we can turn into follow-up bugs.

Comment 9

[Les Orchard [:lorchard]]

Some quick feedback:

* Would be nice if the "Save" icon in the ckeditor toolbar saved changes. I'm not sure how to save the changes otherwise. 

* The "edit" links disappear when I click one. Not sure how to cancel editing a section and edit another, if I mistakenly click the wrong edit link.

For the longer term, I just filed bug 678498 to tackle per-section edits with server-side implementation. We can probably upgrade this client-side only approach with server-side section handling that works better with simultaneous edits to a single page.

Comment 10

[Janet Swisher]

Clicking outside the editor frame saves and closes the editor. I'd prefer to have a Save (and/or Close) button. Sometimes I might want to scroll and look at other parts of the document while I'm editing a section; if I accidentally click during that process, I don't want that to close my editor.

Comment 11

[Eric Shepherd [:sheppy]]

I agree with Janet; it's far too easy to accidentally close the editor right now. Like, I keep doing it without meaning to so often I can't easily test further.

Comment 12

[Luke Crouch [:groovecoder]]

changed to save on the button instead of on blur. should be live on kuma-stage in a few minutes.