Closed Bug 665780 Opened 13 years ago Closed 13 years ago

Racy code in background_update of test_blocklistchange.js

Categories

(Toolkit :: Add-ons Manager, defect)

defect
Not set
normal

Tracking

()

VERIFIED FIXED
mozilla7

People

(Reporter: mossop, Assigned: mossop)

References

Details

Attachments

(1 file)

background_update assumes that addons-background-update-complete will be called after any new updates are started and before they finish downloading and installing however there is another thing going on, the AMO metadata request which may delay the addons-background-update-complete notification if it takes a while. This patch ensures that we only call the callback once in that situation.

Not sure exactly why this is happening but it appears to be the cause of bug 665624
Attached patch patch rev 1Splinter Review
Comment on attachment 540612 [details] [diff] [review]
patch rev 1

We've confirmed that this solves the problem
Attachment #540612 - Flags: review?(robert.bugzilla)
Attachment #540612 - Flags: review?(robert.bugzilla) → review+
Dave, can we land this for you, if you've not got time?
Oops, must have missed the review mail. Feel free to land it, I won't be able to till tomorrow now.
Pushed:
http://hg.mozilla.org/mozilla-central/rev/5544f74c84b9
Status: NEW → RESOLVED
Closed: 13 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Whiteboard: [inbound]
Target Milestone: --- → mozilla7
Marking as verified fixed based on check-in and no failing tests in the last two weeks.
Status: RESOLVED → VERIFIED
Flags: in-litmus-
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: