665806 - Remove some stringbundle duplication in preferences

Status: RESOLVED FIXED

(SeaMonkey :: Preferences, defect)

Description

[Ian Neal]

Attachment: prefutilties stringbundle deduplication [Checked in: Comment 2]

At the moment both pref-fonts and pref-sync load the prefutilities stringbundle even though it has already been loaded in preferences.xul.
This patch:
* Removes the stringbundle from pref-fonts.xul
* Removes the stringbundle load from pref-sync.js
* Changes pref-fonts.js and pref-sync.js to use the stringbundle from preferences.xul

Comment 1

[Karsten Düsterloh]

Comment on attachment 540634 [details] [diff] [review]
prefutilties stringbundle deduplication [Checked in: Comment 2]

Review of attachment 540634 [details] [diff] [review]:
-----------------------------------------------------------------

::: suite/common/pref/pref-fonts.js
@@ +86,5 @@
>      if (defaultFont)
>      {
> +      var prefutilitiesBundle = document.getElementById("bundle_prefutilities");
> +      var label = prefutilitiesBundle.getFormattedString("labelDefaultFont",
> +                                                         [defaultFont]);

No need to wrap here, imo.

Comment 2

[Ian Neal]

Comment on attachment 540634 [details] [diff] [review]
prefutilties stringbundle deduplication [Checked in: Comment 2]

http://hg.mozilla.org/comm-central/rev/94a1caddda37