Remove some stringbundle duplication in preferences

RESOLVED FIXED in seamonkey2.4

Status

RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: iann_bugzilla, Assigned: iann_bugzilla)

Tracking

Trunk
seamonkey2.4
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

7 years ago
Created attachment 540634 [details] [diff] [review]
prefutilties stringbundle deduplication [Checked in: Comment 2]

At the moment both pref-fonts and pref-sync load the prefutilities stringbundle even though it has already been loaded in preferences.xul.
This patch:
* Removes the stringbundle from pref-fonts.xul
* Removes the stringbundle load from pref-sync.js
* Changes pref-fonts.js and pref-sync.js to use the stringbundle from preferences.xul
Attachment #540634 - Flags: review?(mnyromyr)

Comment 1

7 years ago
Comment on attachment 540634 [details] [diff] [review]
prefutilties stringbundle deduplication [Checked in: Comment 2]

Review of attachment 540634 [details] [diff] [review]:
-----------------------------------------------------------------

::: suite/common/pref/pref-fonts.js
@@ +86,5 @@
>      if (defaultFont)
>      {
> +      var prefutilitiesBundle = document.getElementById("bundle_prefutilities");
> +      var label = prefutilitiesBundle.getFormattedString("labelDefaultFont",
> +                                                         [defaultFont]);

No need to wrap here, imo.
Attachment #540634 - Flags: review?(mnyromyr) → review+
(Assignee)

Comment 2

7 years ago
Comment on attachment 540634 [details] [diff] [review]
prefutilties stringbundle deduplication [Checked in: Comment 2]

http://hg.mozilla.org/comm-central/rev/94a1caddda37
Attachment #540634 - Attachment description: prefutilties stringbundle deduplication → prefutilties stringbundle deduplication [Checked in: Comment 2]
(Assignee)

Updated

7 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.4
You need to log in before you can comment on or make changes to this bug.