Closed
Bug 665836
Opened 14 years ago
Closed 14 years ago
Updates to the avm unit test script broke it in AOT mode
Categories
(Tamarin Graveyard :: Virtual Machine, defect, P2)
Tamarin Graveyard
Virtual Machine
Tracking
(Not tracked)
RESOLVED
FIXED
Q3 11 - Serrano
People
(Reporter: almancha, Assigned: almancha)
Details
(Whiteboard: fixed-in-tr, WE:2865886)
Attachments
(1 file)
|
4.73 KB,
patch
|
stejohns
:
review+
cpeyer
:
review+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_6_7) AppleWebKit/534.30 (KHTML, like Gecko) Chrome/12.0.742.100 Safari/534.30
Build Identifier:
The AVM unit test script was updated in a manner which broke it for AOT mode. Specifically:
1) Test config was not parsed before compiling in AOT mode
2) Tests were not AOT compiled
3) Incorrect jar used to AOT compile (pfi instead of adt)
Reproducible: Always
|
Assignee | |
Comment 1•14 years ago
|
||
Attachment #540681 -
Flags: review?(stejohns)
|
|
Assignee | |
Comment 2•14 years ago
|
||
Steven, if the changes look ok, would you please push them to tamarin? Thanks much!
-alok.
|
||
Updated•14 years ago
|
Attachment #540681 -
Flags: review?(cpeyer)
|
||
Comment 3•14 years ago
|
||
Comment on attachment 540681 [details] [diff] [review]
Proposed fix
Review of attachment 540681 [details] [diff] [review]:
-----------------------------------------------------------------
Looks fine to me, but I need to defer to Chris on the python change, it's not code I know well.
Attachment #540681 -
Flags: review?(stejohns) → review+
|
||
Updated•14 years ago
|
Attachment #540681 -
Flags: review?(cpeyer) → review+
|
||
Comment 4•14 years ago
|
||
changeset: 6408:b9e17ff36da6
user: Chris Peyer <cpeyer@adobe.com>
summary: Bug 665836: AOT Mode test script fixes (p=amanchanda, r=cpeyer)
http://hg.mozilla.org/tamarin-redux/rev/b9e17ff36da6
|
||
Updated•14 years ago
|
Whiteboard: fixed-in-tr
|
|
||
Updated•14 years ago
|
Whiteboard: fixed-in-tr → fixed-in-tr, WE:2865886
Target Milestone: --- → Q3 11 - Serrano
Assignee: nobody → almancha
Flags: flashplayer-qrb+
Priority: -- → P2
Status: UNCONFIRMED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•