Delete old .gcda / .pgd files during NSPR PROFILE_GENERATE phase

RESOLVED FIXED in 4.8.9

Status

RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: justin.lebar+bug, Assigned: justin.lebar+bug)

Tracking

other
4.8.9
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [fixed in nspr])

Attachments

(1 attachment)

(Assignee)

Description

7 years ago
Bug 659942 fixed this for everywhere save NSPR, but we should also fix it for NSPR, even though I doubt that fixing this bug will fix bug 653961.

Patch in a moment.
(Assignee)

Comment 1

7 years ago
Created attachment 540823 [details] [diff] [review]
Patch v1

This is kind of a hack; it always deletes both .gcda and .pgd files, because I
wasn't sure how to properly detect GCC (GNU_CC is not defined).  I don't think
that's a big deal, but I'm happy to change it.
(Assignee)

Updated

7 years ago
Attachment #540823 - Flags: review?(ted.mielczarek)
(Assignee)

Updated

7 years ago
Assignee: wtc → justin.lebar+bug
(Assignee)

Updated

7 years ago
OS: Linux → All
Hardware: x86_64 → All
Comment on attachment 540823 [details] [diff] [review]
Patch v1

Review of attachment 540823 [details] [diff] [review]:
-----------------------------------------------------------------

::: nsprpub/config/rules.mk
@@ +382,5 @@
> +# Clean up profiling data during PROFILE_GENERATE phase
> +export::
> +	-$(RM) *.pgd *.gcda
> +endif
> +

This should be fine, since $(RM) is "rm -f", so removing things that aren't there isn't harmful.
Attachment #540823 - Flags: review?(ted.mielczarek) → review+
(Assignee)

Updated

7 years ago
Keywords: checkin-needed
Whiteboard: [needs checkin to NSPR]
Checking in config/rules.mk;
/cvsroot/mozilla/nsprpub/config/rules.mk,v  <--  rules.mk
new revision: 3.81; previous revision: 3.80
done
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → 4.9

Updated

7 years ago
Target Milestone: 4.9 → 4.8.9
(Assignee)

Updated

7 years ago
Keywords: checkin-needed
Whiteboard: [needs checkin to NSPR] → [fixed in nspr]
Depends on: 675084
You need to log in before you can comment on or make changes to this bug.