665978 - Delete old .gcda / .pgd files during NSPR PROFILE_GENERATE phase

Status: RESOLVED FIXED

(NSPR :: NSPR, defect)

Description

[Justin Lebar (not reading bugmail)]

Bug 659942 fixed this for everywhere save NSPR, but we should also fix it for NSPR, even though I doubt that fixing this bug will fix bug 653961.

Patch in a moment.

Comment 1

[Justin Lebar (not reading bugmail)]

Attachment: Patch v1

This is kind of a hack; it always deletes both .gcda and .pgd files, because I
wasn't sure how to properly detect GCC (GNU_CC is not defined).  I don't think
that's a big deal, but I'm happy to change it.

Comment 2

[(not currently active) Ted Mielczarek]

Comment on attachment 540823 [details] [diff] [review]
Patch v1

Review of attachment 540823 [details] [diff] [review]:
-----------------------------------------------------------------

::: nsprpub/config/rules.mk
@@ +382,5 @@
> +# Clean up profiling data during PROFILE_GENERATE phase
> +export::
> +	-$(RM) *.pgd *.gcda
> +endif
> +

This should be fine, since $(RM) is "rm -f", so removing things that aren't there isn't harmful.

Comment 3

[(not currently active) Ted Mielczarek]

Checking in config/rules.mk;
/cvsroot/mozilla/nsprpub/config/rules.mk,v  <--  rules.mk
new revision: 3.81; previous revision: 3.80
done