666008 - Deprecate or remove controller.assertX functions

Status: RESOLVED FIXED

(Testing Graveyard :: Mozmill, defect)

Description

[Heather Arthur [:harth]]

From bug 650963, we should deprecate or remove all the controller.assertBlahBlahBlah() functions in favor of the assert and expect modules.

Comment 1

[Heather Arthur [:harth]]

Attachment: Deprecate controller.assertX() methods

This deprecates them. The only problem with this is you don't see the warnings unless you do --console-level=DEBUG.

Comment 2

[cmtalbert]

Comment on attachment 540859 [details]
Deprecate controller.assertX() methods

Nit: Calling the function logDeprecated makes it sound like a general deprecation utility, so either parameterize it with a message param so that it is a generic deprecation logging utilty or call it logDeprecatedAssert so that it's clear this is a one-time use thing.

I tend to prefer the general approach where it takes the API name and the message as parameters and prints the same standardized message that you have there, just by using the passed in message and funcname parameters.  Make sense?

Comment 3

[Heather Arthur [:harth]]

comments addressed, thanks clint, master:
https://github.com/mozautomation/mozmill/commit/0173de6c6a8198b1b3c4090bb30a18cfdc75781e