GCLI completer text doesn't line up with the inputter text



8 years ago
9 months ago


(Reporter: fitzgen, Unassigned)


Firefox Tracking Flags

(Not tracked)



(3 attachments, 1 obsolete attachment)

Created attachment 540906 [details]
Example of the mis-alignment
Created attachment 540923 [details] [diff] [review]
Hacky patch to fix the mis-alignment

Joe, this fixes the issue on my machine, but I am not sure it would work on all machines across the board. What would be a better way to fix this problem?
Attachment #540923 - Flags: feedback?(jwalker)
Created attachment 540925 [details]
Example of how the mis-alignment is fixed (at least on my machine)
Just realized that this patch wrecks the existing jsterm's text alignment.
Created attachment 540941 [details]
New patch

It seems that the reason the font alignment was messed up for GCLI but not jsterm is because jsterm uses a textbox element for the completer's node, but GCLI uses a div. I looked in to the styles that are applied to textboxes by default and it turns out that they have some margin by default!
Attachment #540923 - Attachment is obsolete: true
Attachment #540941 - Flags: feedback?(jwalker)
Attachment #540923 - Flags: feedback?(jwalker)
Comment on attachment 540941 [details]
New patch

It seems like a standard for CSS files to not have the tag name in there. i.e. s/div.jsterm/.jsterm/ and I know from previous work that the CSS files sometimes get significant scrutiny, so it's probably worth fixing.

We should (but to-date I have not) make similar changes in pinstripe/winstripe and gnomestripe. I'm guessing you're on a mac (pinstripe) so you won't easily be able to test the other configs anyway. I've vagely planned on doing that towards the end of the cycle (I've got a PC on order, which will help too)
Comment on attachment 540941 [details]
New patch

f+ the patch when the div part of the selector is gone.
Attachment #540941 - Flags: feedback?(jwalker) → feedback+
Blocks: 659061
No longer blocks: 663120
Depends on: 666334
Can't happen until https://bugzilla.mozilla.org/show_bug.cgi?id=666334 is completed because the div prefix is required b/c of the textbox vs. div default style issues that I mention above.
Last Resolved: 8 years ago
Resolution: --- → FIXED


9 months ago
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.