666047 - GCLI completer text doesn't line up with the inputter text

Status: RESOLVED FIXED

(DevTools :: General, defect)

Description

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Attachment: Example of the mis-alignment

Comment 1

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Attachment: Hacky patch to fix the mis-alignment

Joe, this fixes the issue on my machine, but I am not sure it would work on all machines across the board. What would be a better way to fix this problem?

Comment 2

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Attachment: Example of how the mis-alignment is fixed (at least on my machine)

Comment 3

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Just realized that this patch wrecks the existing jsterm's text alignment.

Comment 4

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Attachment: New patch

It seems that the reason the font alignment was messed up for GCLI but not jsterm is because jsterm uses a textbox element for the completer's node, but GCLI uses a div. I looked in to the styles that are applied to textboxes by default and it turns out that they have some margin by default!

Comment 5

[Joe Walker [:jwalker]]

Comment on attachment 540941 [details]
New patch


It seems like a standard for CSS files to not have the tag name in there. i.e. s/div.jsterm/.jsterm/ and I know from previous work that the CSS files sometimes get significant scrutiny, so it's probably worth fixing.

We should (but to-date I have not) make similar changes in pinstripe/winstripe and gnomestripe. I'm guessing you're on a mac (pinstripe) so you won't easily be able to test the other configs anyway. I've vagely planned on doing that towards the end of the cycle (I've got a PC on order, which will help too)

Comment 6

[Joe Walker [:jwalker]]

Comment on attachment 540941 [details]
New patch

f+ the patch when the div part of the selector is gone.

Comment 7

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Can't happen until https://bugzilla.mozilla.org/show_bug.cgi?id=666334 is completed because the div prefix is required b/c of the textbox vs. div default style issues that I mention above.