Closed
Bug 666047
Opened 14 years ago
Closed 14 years ago
GCLI completer text doesn't line up with the inputter text
Categories
(DevTools :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: fitzgen, Unassigned)
References
Details
Attachments
(3 files, 1 obsolete file)
No description provided.
Reporter | ||
Comment 1•14 years ago
|
||
Joe, this fixes the issue on my machine, but I am not sure it would work on all machines across the board. What would be a better way to fix this problem?
Attachment #540923 -
Flags: feedback?(jwalker)
Reporter | ||
Comment 2•14 years ago
|
||
Reporter | ||
Comment 3•14 years ago
|
||
Just realized that this patch wrecks the existing jsterm's text alignment.
Reporter | ||
Comment 4•14 years ago
|
||
It seems that the reason the font alignment was messed up for GCLI but not jsterm is because jsterm uses a textbox element for the completer's node, but GCLI uses a div. I looked in to the styles that are applied to textboxes by default and it turns out that they have some margin by default!
Attachment #540923 -
Attachment is obsolete: true
Attachment #540941 -
Flags: feedback?(jwalker)
Attachment #540923 -
Flags: feedback?(jwalker)
Comment 5•14 years ago
|
||
Comment on attachment 540941 [details]
New patch
It seems like a standard for CSS files to not have the tag name in there. i.e. s/div.jsterm/.jsterm/ and I know from previous work that the CSS files sometimes get significant scrutiny, so it's probably worth fixing.
We should (but to-date I have not) make similar changes in pinstripe/winstripe and gnomestripe. I'm guessing you're on a mac (pinstripe) so you won't easily be able to test the other configs anyway. I've vagely planned on doing that towards the end of the cycle (I've got a PC on order, which will help too)
Comment 6•14 years ago
|
||
Comment on attachment 540941 [details]
New patch
f+ the patch when the div part of the selector is gone.
Attachment #540941 -
Flags: feedback?(jwalker) → feedback+
Reporter | ||
Updated•14 years ago
|
Reporter | ||
Comment 7•14 years ago
|
||
Can't happen until https://bugzilla.mozilla.org/show_bug.cgi?id=666334 is completed because the div prefix is required b/c of the textbox vs. div default style issues that I mention above.
Updated•14 years ago
|
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Updated•7 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•