Closed Bug 666132 Opened 9 years ago Closed 9 years ago

ASSERTION: Decoded samples for Vorbis packet don't match expected

Categories

(Core :: Audio/Video, defect)

x86
Windows 7
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla8

People

(Reporter: cpearce, Assigned: cajbir)

References

()

Details

(Whiteboard: [inbound])

Attachments

(2 files, 1 obsolete file)

The code to predict the number of samples in an Ogg Vorbis packet is firing an assertion while decoding many of the Ogg files in the Pirates Love Daisies HTML5 demo. e.g.:

http://www.pirateslovedaisies.com/audio/units/U-Thug8.ogg

7672[bae9d60]: ###!!! ASSERTION: Decoded samples for Vorbis packet don't match expected!: 'mVorbisPacketSamples[aPacket] == aSamples', file c:/Users/cpearce/src/blue/objdir/conten
/media/ogg/../../../../content/media/ogg/nsOggCodecState.cpp, line 126
###!!! ASSERTION: Decoded samples for Vorbis packet don't match expected!: 'mVorbisPacketSamples[aPacket] == aSamples', file c:/Users/cpearce/src/blue/objdir/content/media/ogg/../
./../../content/media/ogg/nsOggCodecState.cpp, line 126
Attached video Test file
I've attached a test file that also causes the assertion. The file is from the test in bug 668449 comment 6.
Assignee: nobody → chris.double
Attached patch Fix (obsolete) — Splinter Review
Account for trailing data in the last frame of vorbis file when doing debug sanity checks.
Attachment #550010 - Flags: review?(chris)
Comment on attachment 550010 [details] [diff] [review]
Fix

>+    // Account for a partial last frame
>+    if (packet->e_o_s && packet->granulepos > mGranulepos) {
>+       samples = packet->granulepos - mGranulepos;
>+    }

Is there a particular reason you're using > instead of >=? I don't see an explicit limit in the spec on how many samples can be trimmed by a short granpos on the last page, but I know that at the start of the stream, removing _all_ the samples from the packet (to give a granpos of 0) is explicitly allowed.
Attached patch FixSplinter Review
Thanks Tim, I wasn't aware of that. Changed to >= as per your suggestion in comment 3.
Attachment #550010 - Attachment is obsolete: true
Attachment #550048 - Flags: review?(chris)
Attachment #550010 - Flags: review?(chris)
Attachment #550048 - Flags: review?(chris) → review+
http://hg.mozilla.org/mozilla-central/rev/e8fe55848089
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla8
You need to log in before you can comment on or make changes to this bug.