666139 - backport upstream's 'bugmail_new_prefix' prefix

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: Extensions, defect)

Description

[:glob ✱]

with the user setting 'bugmail_new_prefix' going in upstream via bug 663747, we need to:

1. backport the fix to bmo/4.0
2. delete the GmailThreading extension
3. migrate existing user preferences from 'gmail_threading' to 'bugmail_new_prefix'


the migration should happen automatically in checksetup (probably from the BMO extension) and needs to rename each 'gmail_threading' entry in profile_setting as well as inverting the preference (ie.  gmail_threading.on ==> bugmail_new_prefix.off).  once profile_settings has been updated, gmail_threading can be removed from the 'setting' table.

Comment 1

[:glob ✱]

Attachment: patch v1

Comment 2

[David Lawrence [:dkl]]

Comment on attachment 542403 [details] [diff] [review]
patch v1

Review of attachment 542403 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good and works as expected. r=dkl

Comment 3

[:glob ✱]

Committing to: bzr+ssh://[e-mail]/bmo/4.0/
modified Bugzilla/Install.pm
modified extensions/GmailThreading
modified extensions/BMO/Extension.pm
modified extensions/GmailThreading/Config.pm
modified extensions/GmailThreading/Extension.pm
modified extensions/GmailThreading/template
modified extensions/GmailThreading/template/en
modified extensions/GmailThreading/template/en/default
modified extensions/GmailThreading/template/en/default/hook
modified extensions/GmailThreading/template/en/default/hook/global
modified extensions/GmailThreading/template/en/default/hook/global/setting-descs-settings.none.tmpl
modified template/en/default/email/newchangedmail.txt.tmpl
modified template/en/default/global/setting-descs.none.tmpl
Committed revision 7795.