666140 - client.mk should fail if MOZCONFIG is specified but points to a nonexistent file

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Jez Ng [:int3]]

User-Agent:       Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:5.0) Gecko/20100101 Firefox/5.0
Build Identifier: 

I spent a good deal of time trying to figure out why my builds weren't working as expected, when I realized that my MOZCONFIG environment variable was actually pointing to a nonexistent file, and the build was just using its default options. I feel that the build system should highlight this error instead of defaulting silently.

Reproducible: Always

Comment 1

[Jez Ng [:int3]]

Attachment: Fix for the issue described.

Comment 2

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Comment on attachment 540980 [details] [diff] [review]
Fix for the issue described.

>+  if [ -n "$_config" ] && ! [ -f "$_config" ]; then

This should be ||, no?

Comment 3

[Jez Ng [:int3]]

Nope. If _config is not defined, then we should look for the mozconfig file in the default places like ~/.mozconfig. But if it is defined _and_ points to a file that doesn't exist, then we should throw an error.

Comment 4

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

My bad, I read another ! in there because that's what I expected.

Comment 5

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

http://hg.mozilla.org/projects/build-system/rev/8625f655aeec

Comment 6

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

http://hg.mozilla.org/mozilla-central/rev/8625f655aeec

Comment 7

[David :Bienvenu]

this broke my pymake builds of Thunderbird. For those builds, I set MOZCONFIG to /c/builds/<tree>/mozconfig, which was working earlier.

Comment 8

[Benjamin Smedberg]

Does it not work to set MOZCONFIG=c:/builds/<tree>/mozconfig?

Comment 9

[David :Bienvenu]

(In reply to comment #8)
> Does it not work to set MOZCONFIG=c:/builds/<tree>/mozconfig?

No, it fails the same way:

g --disable-optimize --enable-chrome-format=jar --enable-application=../mail --d
isable-official-branding --with-branding=../mail/branding/nightly --cache-file=.
././config.cache --srcdir=../../mozilla
../../mozilla/./build/autoconf/mozconfig2configure: line 118: Specified MOZCONFI
G "../.mozconfig" does not exist!: No such file or directory
configure: error: ../../mozilla/configure failed for mozilla

It's odd that it's looking for ../.mozconfig - maybe it's an issue that Thunderbird builds out of <tree>/mozilla

Comment 10

[[e-mail]]

Also breaks for me using a relative configure i.e. invoking ../configure with my mozconfig living in my srcdir so not actually specified in $MOZCONFIG.

Comment 11

[Rain [:rain1] (inactive)]

Strange, running MOZCONFIG=/c/Users/Sid/mozilla/comm-central/.mozconfig-opt ../configure works fine for me with an updated mozilla-central.

Comment 12

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

So ... do we need to back this out our not?