666257 - Connect to Sync popup is not dismissed when device Back button is tapped in Awesome bar/Desktop Tab

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect, P3)

Description

[Cristian Nicolae (:xti)]

Build id : Mozilla/5.0 (Android;Linux armv7l;rv:7.0a1)Gecko/20110621
Firefox/7.0a1 Fennec/7.0a1
Device: Motorola Droid 2
OS: Android 2.2

Steps to reproduce:
1. Open Fennec app
2. Tap on URL Bar
3. Tap on Desktop Tab
4. Tap device Back button twice

Expected result:
After step 4, the opened Sync popup at step 3 is dismissed.

Actual result:
Connect to sync popup is not dismissed, no matter how many taps are performed at step 4.

Note:
Device should not be connected to Sync before performing the first step!

Comment 1

[Lucas Rocha (:lucasr)]

Taking.

Comment 2

[Lucas Rocha (:lucasr)]

Attachment: Dismiss dialogs before panels

Comment 3

[Lucas Rocha (:lucasr)]

Attachment: Open sync dialog after the panel for correct dialog stacking

Comment 4

[Lucas Rocha (:lucasr)]

Attachment: Remove redundant panel update

Comment 5

[Matt Brubeck (:mbrubeck)]

Comment on attachment 554101 [details] [diff] [review]
Open sync dialog after the panel for correct dialog stacking

Thanks for the good explanatory comments.

Comment 6

[Matt Brubeck (:mbrubeck)]

Comment on attachment 554102 [details] [diff] [review]
Remove redundant panel update

Nice cleanup work!

Comment 7

[Matt Brubeck (:mbrubeck)]

Comment on attachment 554100 [details] [diff] [review]
Dismiss dialogs before panels

I didn't spot the problem in my review, but in testing with this patch I noticed that when I tap in the urlbar, then switch from "All Pages" to any other panel, then pressing escape will no longer work to dismiss the awesomescreen.

Also, s/Escale/Escape/ in the commit message.

Comment 8

[Lucas Rocha (:lucasr)]

Attachment: Dismiss dialogs before panels (fixed commit message)

Matt, This patch is correct. The bug you found is actually caused by a bug in the activePanel setter which I fixed in the patch. I fixed the commit message.

Comment 9

[Lucas Rocha (:lucasr)]

Attachment: Always update dialog stack when setting active panel

This patch should go before all other patches. It fixes dialog stack updates when setting active panels in BrowserUI.

Comment 10

[Lucas Rocha (:lucasr)]

Attachment: Bug 666257 - Always update dialog stack when setting activePanel

Comment 11

[Lucas Rocha (:lucasr)]

Attachment: Bug 666257 - Dismiss dialogs before panels with Escape key

Comment 12

[Lucas Rocha (:lucasr)]

Attachment: Bug 666257 - Connect to Sync popup is not dismissed when device Back button is tapped in Awesome bar/Desktop Tab

Comment 13

[Lucas Rocha (:lucasr)]

Attachment: Bug 666257 - Remove redundant activePanel update

Updated all patches to include bug number and reviewer id.

Comment 14

[Matt Brubeck (:mbrubeck)]

http://hg.mozilla.org/integration/mozilla-inbound/rev/fd7bf2557b25
http://hg.mozilla.org/integration/mozilla-inbound/rev/82b14f7ed86d
http://hg.mozilla.org/integration/mozilla-inbound/rev/d73f45cc0506
http://hg.mozilla.org/integration/mozilla-inbound/rev/1f7abb28b276

Comment 15

[Ed Morley [:emorley]]

http://hg.mozilla.org/mozilla-central/rev/fd7bf2557b25
http://hg.mozilla.org/mozilla-central/rev/82b14f7ed86d
http://hg.mozilla.org/mozilla-central/rev/d73f45cc0506
http://hg.mozilla.org/mozilla-central/rev/1f7abb28b276

Comment 16

[Aaron Train [:aaronmt]]

Mozilla/5.0 (Android; Linux armv7l; rv:9.0a1) Gecko/20110830 Firefox/9.0a1 Fennec/9.0a1