66628 - clean up the XULSortService to use the tree batching API

Status: RESOLVED WONTFIX

(Core Graveyard :: RDF, defect)

Description

[(not reading, please use [e-mail] instead)]

as long as TreeBoxObject::BeginBatch() / TreeBoxObject::EndBatch() does the
right thing, we can clean up some of the code in XULSortService::DoSort().

I'll attach a patch.

Comment 1

[(not reading, please use [e-mail] instead)]

Attachment: patch, details to follow

Comment 2

[(not reading, please use [e-mail] instead)]

in that patch, I fixed some warnings, switched over to the tree batching api,
and added some timing code.

while working on mailnews sort performance, I found that timing code very
useful.

accepting, adding dependency on a tree batching bug #66583

Comment 3

[(not reading, please use [e-mail] instead)]

well, I have no plans on doing this now.

in mailnews, we are doing the sorting in our view.  giving this to waterson.

feel free to mark this wont fix.

Comment 4

[Chase Tingley]

I'm going to try to fold this in to my work on bug 105783.

Comment 5

[Chase Tingley]

I had this patch in my tree for a bit, but things were acting strangely -- I was
getting crashes when trying to scroll after doing a quicksort on a tree.  I'll
try to investigate at some point.

Comment 6

[Joe Hewitt (gone)]

tree batching? we don't got no stinking tree batching

Comment 7

[benc]

tever is not RDF QA anymore