[highlighter] make sure devtools.inspector.enabled is preffed off if not ready

VERIFIED FIXED

Status

()

Firefox
Developer Tools
VERIFIED FIXED
6 years ago
3 years ago

People

(Reporter: rc, Assigned: rc)

Tracking

unspecified
Points:
---

Firefox Tracking Flags

(firefox7+ fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
With the landing of the new highlighter code in bug 642471, we need to make sure that the highlighter and inspector feature is ready for shipping. We should track this through the firefox 7 release and adjust the pref before merge as-needed.
(Assignee)

Updated

6 years ago
Summary: [highlighter] make sure devtools.inspector.enabled is prefed off if not ready → [highlighter] make sure devtools.inspector.enabled is preffed off if not ready

Updated

6 years ago
tracking-firefox7: ? → +
(Assignee)

Updated

6 years ago
Assignee: nobody → rcampbell
Status: NEW → ASSIGNED
So, we're on aurora now. Rob - are we killing the inspector pref?
(Assignee)

Comment 2

6 years ago
Yes. Patch forthcoming.
(Assignee)

Comment 3

6 years ago
Created attachment 546866 [details] [diff] [review]
inspector disabled
Attachment #546866 - Flags: review?(gavin.sharp)
Attachment #546866 - Flags: approval-mozilla-aurora?

Comment 4

6 years ago
Comment on attachment 546866 [details] [diff] [review]
inspector disabled

approved conditional on the positive review.
Attachment #546866 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment on attachment 546866 [details] [diff] [review]
inspector disabled

Seems like you need to adjust the comment too (i.e. just revert http://hg.mozilla.org/mozilla-central/rev/96c76749e35f#l1.1 )
Attachment #546866 - Flags: review?(gavin.sharp) → review+
(Assignee)

Comment 6

6 years ago
Comment on attachment 546866 [details] [diff] [review]
inspector disabled

landed on aurora:

http://hg.mozilla.org/releases/mozilla-aurora/rev/1b4168e307fb
Attachment #546866 - Flags: checkin+
(Assignee)

Updated

6 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED

Updated

6 years ago
status-firefox7: --- → fixed

Comment 7

6 years ago
Mozilla/5.0 (Windows NT 5.1; rv:7.0) Gecko/20100101 Firefox/7.0

Verified issue on Win XP, Win 7, Mac OS X 10.6 and Ubuntu 11.04 - devtools.inspector.enabled is preffed off.

Setting resolution to VERIFIED FIXED.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.