Closed
Bug 666402
Opened 14 years ago
Closed 14 years ago
Remove jsdouble
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
DUPLICATE
of bug 725550
People
(Reporter: paul.biggar, Assigned: paul.biggar)
References
Details
Attachments
(3 files)
1.55 KB,
patch
|
luke
:
review+
dmandelin
:
superreview-
|
Details | Diff | Splinter Review |
182.19 KB,
patch
|
Waldo
:
review+
|
Details | Diff | Splinter Review |
14.62 KB,
patch
|
Details | Diff | Splinter Review |
jsdouble is just a double.
Attached is part 3, which moves jsdouble into jsdeprecate.h. This is based on bug 666316.
Parts 1 and 2 to follow, but they are just automatic search/replace.
Attachment #541192 -
Flags: superreview?(dmandelin)
Attachment #541192 -
Flags: review?(luke)
Assignee | ||
Comment 1•14 years ago
|
||
Part 2: changes within the JS engine. This was an automatic search/replace using dedeprecate.pl. I did some manual checking and indentation fixes, just to be sure.
Assignee: general → pbiggar
Attachment #541198 -
Flags: review?(jwalden+bmo)
Assignee | ||
Comment 2•14 years ago
|
||
Part 3, again done by search/replace, is changes outside the JS engine. The changes are in these files:
M content/base/public/nsContentUtils.h
M content/canvas/src/CustomQS_Canvas2D.h
M dom/base/nsDOMClassInfo.cpp
M dom/plugins/base/nsJSNPRuntime.cpp
M js/jsd/jsd.h
M js/jsd/jsd_scpt.c
M js/jsd/jsd_step.c
M js/jsd/jsd_val.c
M js/jsd/jsdebug.c
M js/jsd/jsdebug.h
M toolkit/components/places/History.cpp
Do I need approval for each module this touches, or do we have blanket approval for simple changes like this?
Attachment #541207 -
Flags: review?(dmandelin)
Updated•14 years ago
|
Attachment #541198 -
Flags: review?(jwalden+bmo) → review+
Updated•14 years ago
|
Attachment #541192 -
Flags: review?(luke) → review+
Comment 3•14 years ago
|
||
http://www.open-std.org/jtc1/sc22/wg14/www/standards made MEGO, but it appears that double is not guaranteed to be IEEE 64-bit binary floating point. At least, that was the case with earlier C standards, when jsdouble was minted. We had to fend off crazy platforms that made double (not long double) 80-bit. True story!
I hope this is a non-issue. If not this bug might be INVALID.
/be
Comment 4•14 years ago
|
||
Comment on attachment 541207 [details] [diff] [review]
changes outside the JS engine
>--- a/js/jsd/jsd.h
>+++ b/js/jsd/jsd.h
>@@ -206,22 +206,22 @@ struct JSDScript
> struct JSDProfileData
> {
> JSDProfileData* caller;
> int64 lastCallStart;
> int64 runningTime;
> uintN callCount;
> uintN recurseDepth;
> uintN maxRecurseDepth;
>- jsdouble minExecutionTime;
>- jsdouble maxExecutionTime;
>- jsdouble totalExecutionTime;
>- jsdouble minOwnExecutionTime;
>- jsdouble maxOwnExecutionTime;
>- jsdouble totalOwnExecutionTime;
>+ double minExecutionTime;
>+ double maxExecutionTime;
>+ double totalExecutionTime;
>+ double minOwnExecutionTime;
>+ double maxOwnExecutionTime;
>+ double totalOwnExecutionTime;
Reindent?
Comment 5•14 years ago
|
||
Comment on attachment 541192 [details] [diff] [review]
jsapi changes
We're not going to do this one right now--we have bigger fish to fry.
Attachment #541192 -
Flags: superreview?(dmandelin) → superreview-
Updated•14 years ago
|
Attachment #541207 -
Flags: review?(dmandelin)
Updated•14 years ago
|
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → WONTFIX
Updated•13 years ago
|
Resolution: WONTFIX → DUPLICATE
You need to log in
before you can comment on or make changes to this bug.
Description
•