666402 - Remove jsdouble

Status: RESOLVED DUPLICATE of bug 725550

(Core :: JavaScript Engine, defect)

Description

[Paul Biggar]

Attachment: jsapi changes

jsdouble is just a double.

Attached is part 3, which moves jsdouble into jsdeprecate.h. This is based on bug 666316.

Parts 1 and 2 to follow, but they are just automatic search/replace.

Comment 1

[Paul Biggar]

Attachment: jsdouble changes within the JS engine

Part 2: changes within the JS engine. This was an automatic search/replace using dedeprecate.pl. I did some manual checking and indentation fixes, just to be sure.

Comment 2

[Paul Biggar]

Attachment: changes outside the JS engine

Part 3, again done by search/replace, is changes outside the JS engine. The changes are in these files:

M content/base/public/nsContentUtils.h
M content/canvas/src/CustomQS_Canvas2D.h
M dom/base/nsDOMClassInfo.cpp
M dom/plugins/base/nsJSNPRuntime.cpp
M js/jsd/jsd.h
M js/jsd/jsd_scpt.c
M js/jsd/jsd_step.c
M js/jsd/jsd_val.c
M js/jsd/jsdebug.c
M js/jsd/jsdebug.h
M toolkit/components/places/History.cpp

Do I need approval for each module this touches, or do we have blanket approval for simple changes like this?

Comment 3

[Brendan Eich [:brendan]]

http://www.open-std.org/jtc1/sc22/wg14/www/standards made MEGO, but it appears that double is not guaranteed to be IEEE 64-bit binary floating point. At least, that was the case with earlier C standards, when jsdouble was minted. We had to fend off crazy platforms that made double (not long double) 80-bit. True story!

I hope this is a non-issue. If not this bug might be INVALID.

/be

Comment 4

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 541207 [details] [diff] [review]
changes outside the JS engine

>--- a/js/jsd/jsd.h
>+++ b/js/jsd/jsd.h
>@@ -206,22 +206,22 @@ struct JSDScript
> struct JSDProfileData
> {
>     JSDProfileData* caller;
>     int64    lastCallStart;
>     int64    runningTime;
>     uintN    callCount;
>     uintN    recurseDepth;
>     uintN    maxRecurseDepth;
>-    jsdouble minExecutionTime;
>-    jsdouble maxExecutionTime;
>-    jsdouble totalExecutionTime;
>-    jsdouble minOwnExecutionTime;
>-    jsdouble maxOwnExecutionTime;
>-    jsdouble totalOwnExecutionTime;
>+    double minExecutionTime;
>+    double maxExecutionTime;
>+    double totalExecutionTime;
>+    double minOwnExecutionTime;
>+    double maxOwnExecutionTime;
>+    double totalOwnExecutionTime;

Reindent?

Comment 5

[David Mandelin [:dmandelin]]

Comment on attachment 541192 [details] [diff] [review]
jsapi changes

We're not going to do this one right now--we have bigger fish to fry.